diff options
| author | Ivan Secerin <ivan.severin.m@gmail.com> | 2018-03-20 17:40:40 +0200 |
|---|---|---|
| committer | Pascal Quantin <pascal.quantin@gmail.com> | 2018-03-21 09:14:59 +0000 |
| commit | 10c508ebf828e8062d3cbab899ea5fb1031ca59d (patch) | |
| tree | 09f44a3061aaceb82820a834c320d84c2d4ce33a /epan/dissectors/packet-wsp.c | |
| parent | 979808091d118788b42f7eab5a8f09e4d805f3ae (diff) | |
packet-wsp: fixed incorrect invalid header handling
In function 'add_header' coŠ³ple of if-statements didn't corespond
to comments above.
Change-Id: Idd846cebf7e17d0e2f49c7c7d3de466b899c73c6
Reviewed-on: https://code.wireshark.org/review/26573
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-wsp.c')
| -rw-r--r-- | epan/dissectors/packet-wsp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/dissectors/packet-wsp.c b/epan/dissectors/packet-wsp.c index c5ad4aa7a0..ef97de2528 100644 --- a/epan/dissectors/packet-wsp.c +++ b/epan/dissectors/packet-wsp.c @@ -4400,7 +4400,7 @@ add_headers (proto_tree *tree, tvbuff_t *tvb, int hf, packet_info *pinfo) offset = WellKnownHeader[hdr_id & 0x7F](wsp_headers, tvb, hdr_start, pinfo); /* Make sure we're progressing forward */ - if (save_offset <= offset) { + if (save_offset >= offset) { expert_add_info(pinfo, ti, &ei_wsp_header_invalid); break; } @@ -4411,7 +4411,7 @@ add_headers (proto_tree *tree, tvbuff_t *tvb, int hf, packet_info *pinfo) offset = WellKnownOpenwaveHeader[hdr_id & 0x7F](wsp_headers, tvb, hdr_start, pinfo); /* Make sure we're progressing forward */ - if (save_offset <= offset) { + if (save_offset >= offset) { expert_add_info(pinfo, ti, &ei_wsp_header_invalid); break; } |