diff options
| author | Michael Mann <mmann78@netscape.net> | 2017-06-04 17:35:15 -0400 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2017-06-05 02:53:35 +0000 |
| commit | d73fdc7079df7875e51d88cf763c0453e8f7c1a8 (patch) | |
| tree | eeee911e7894e5cd4173b31274ce2fe25f59eecb /epan/dissectors/packet-usbip.c | |
| parent | aabb8fd5946110767479e2863ffe4fc40d63ac53 (diff) | |
Remove "length only" check for dissectors that use tcp_dissect_pdus.
If a TCP segment is small enough, dissectors that have a only a length
check determining if it's their packet or not before calling tcp_dissect_pdus
will throw out packets that are probably destined for them.
Change-Id: I78034307b56aa537943191a6887166577936a6a3
Reviewed-on: https://code.wireshark.org/review/21950
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'epan/dissectors/packet-usbip.c')
| -rw-r--r-- | epan/dissectors/packet-usbip.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/epan/dissectors/packet-usbip.c b/epan/dissectors/packet-usbip.c index 4f949e16c9..38e0a443ee 100644 --- a/epan/dissectors/packet-usbip.c +++ b/epan/dissectors/packet-usbip.c @@ -822,12 +822,6 @@ get_usbip_message_len(packet_info *pinfo _U_, tvbuff_t *tvb, int offset, static int dissect_usbip(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data) { - /* Check that there's enough data */ - if (tvb_reported_length(tvb) < 4) { - /* usbip's smallest packet size is 4 */ - return 0; - } - tcp_dissect_pdus(tvb, pinfo, tree, TRUE, FRAME_HEADER_LEN, get_usbip_message_len, dissect_usbip_common, data); |