diff options
| author | Filipe Laíns <lains@archlinux.org> | 2020-07-06 22:57:32 +0100 |
|---|---|---|
| committer | Tomasz Moń <desowin@gmail.com> | 2020-07-07 06:15:04 +0000 |
| commit | 86c27cc1c096e258a2f9119dd3a202d9b77fb118 (patch) | |
| tree | fff17001c411d7719e4322ead3f57d33e929087a /epan/dissectors/packet-usb-hid.c | |
| parent | 2d49ab3d25435be3d15c9a59189f4017db5c5ddb (diff) | |
USB HID: fix parsing {logical ,phys }{min,max} in the report descriptor
Right now, for eg., a -32767/32767 min/max gets dissected as 0/1 which
is wrong.
Change-Id: Iffc649e0af4490827e722cae7f692ec4d0c245b8
Signed-off-by: Filipe Laíns <lains@archlinux.org>
Reviewed-on: https://code.wireshark.org/review/37751
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń <desowin@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-usb-hid.c')
| -rw-r--r-- | epan/dissectors/packet-usb-hid.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/epan/dissectors/packet-usb-hid.c b/epan/dissectors/packet-usb-hid.c index d6eb151a21..de82cfc641 100644 --- a/epan/dissectors/packet-usb-hid.c +++ b/epan/dissectors/packet-usb-hid.c @@ -4711,19 +4711,19 @@ proto_register_usb_hid(void) NULL, 0, NULL, HFILL }}, { &hf_usb_hid_globalitem_log_min, - { "Logical minimum", "usbhid.item.global.log_min", FT_INT8, BASE_DEC, + { "Logical minimum", "usbhid.item.global.log_min", FT_INT32, BASE_DEC, NULL, 0, NULL, HFILL }}, { &hf_usb_hid_globalitem_log_max, - { "Logical maximum", "usbhid.item.global.log_max", FT_INT8, BASE_DEC, + { "Logical maximum", "usbhid.item.global.log_max", FT_INT32, BASE_DEC, NULL, 0, NULL, HFILL }}, { &hf_usb_hid_globalitem_phy_min, - { "Physical minimum", "usbhid.item.global.phy_min", FT_INT8, BASE_DEC, + { "Physical minimum", "usbhid.item.global.phy_min", FT_INT32, BASE_DEC, NULL, 0, NULL, HFILL }}, { &hf_usb_hid_globalitem_phy_max, - { "Physical maximum", "usbhid.item.global.phy_max", FT_INT8, BASE_DEC, + { "Physical maximum", "usbhid.item.global.phy_max", FT_INT32, BASE_DEC, NULL, 0, NULL, HFILL }}, { &hf_usb_hid_globalitem_unit_exp, |