diff options
| author | João Valverde <joao.valverde@tecnico.ulisboa.pt> | 2015-08-19 21:47:50 +0100 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2015-08-20 11:44:21 +0000 |
| commit | 8a7186791c65569f655ad21ebc8309edbecf9552 (patch) | |
| tree | 0e13ed77aa23c36e1b45d95d3c20c48d1e253507 /epan/dissectors/packet-udp.c | |
| parent | bc8b94d571c181258db0344bf3d1ab9523ff04af (diff) | |
UDP jumbogram expert info fix
Change-Id: Ifa6170622bc8331097bc3fe9c567c97ce826c340
Reviewed-on: https://code.wireshark.org/review/10140
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'epan/dissectors/packet-udp.c')
| -rw-r--r-- | epan/dissectors/packet-udp.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/epan/dissectors/packet-udp.c b/epan/dissectors/packet-udp.c index 2c53cbd331..be02886ab7 100644 --- a/epan/dissectors/packet-udp.c +++ b/epan/dissectors/packet-udp.c @@ -151,7 +151,7 @@ static expert_field ei_udp_length = EI_INIT; static expert_field ei_udplite_checksum_coverage = EI_INIT; static expert_field ei_udp_checksum_zero = EI_INIT; static expert_field ei_udp_checksum_bad = EI_INIT; -static expert_field ei_udp_len_zero_bad = EI_INIT; +static expert_field ei_udp_length_bad_zero = EI_INIT; /* Preferences */ @@ -783,8 +783,8 @@ dissect(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, guint32 ip_proto) } else { if (tree) { ti = proto_tree_add_uint(udp_tree, &hfi_udp_length, tvb, offset + 4, 2, udph->uh_ulen); - if (udp_len_zero && (tvb_reported_length(tvb) < 35636)) { - expert_add_info(pinfo, ti, &ei_udp_len_zero_bad); + if (udp_len_zero && (tvb_reported_length(tvb) < 65536)) { + expert_add_info(pinfo, ti, &ei_udp_length_bad_zero); } /* XXX - why is this here, given that this is UDP, not Lightweight UDP? */ hidden_item = proto_tree_add_uint(udp_tree, &hfi_udplite_checksum_coverage, tvb, offset + 4, @@ -1084,7 +1084,7 @@ proto_register_udp(void) { &ei_udplite_checksum_coverage, { "udp.checksum_coverage.expert", PI_MALFORMED, PI_ERROR, "Bad checksum coverage length value", EXPFILL }}, { &ei_udp_checksum_zero, { "udp.checksum.zero", PI_CHECKSUM, PI_ERROR, "Illegal Checksum value (0)", EXPFILL }}, { &ei_udp_checksum_bad, { "udp.checksum_bad.expert", PI_CHECKSUM, PI_ERROR, "Bad checksum", EXPFILL }}, - { &ei_udp_len_zero_bad, { "udp.length_zero_bad", PI_PROTOCOL, PI_WARN, "UDP Length is zero but payload < 65536", EXPFILL }}, + { &ei_udp_length_bad_zero, { "udp.length.bad_zero", PI_PROTOCOL, PI_WARN, "Length is zero but payload < 65536", EXPFILL }}, }; static build_valid_func udp_da_src_values[1] = {udp_src_value}; |