Fix some bugs & do extensive cleanup;

Bugs fixed:
 - Calling col_...() fcns or dissectors under 'if (tree)'
 - Potential buffer overflows (if bad data)
 - Misc incorrect data display issues
Cleanup including;
 - Remove unneeded #includes
 - Fix excessive use of value_strings
 - Use extended value_strings & val_to_str_(ext_)const as appropriate
 - Optimize repeated fetches of the same data from a tvb
 - Do general code simplification
 - Remove or #if 0 unused code;
 - Add XXX comments for code which may be incorrect
 - Remove unneeded prefs callback to proto_reg_handoff...()
 - Remove unneeded use of check_col()
 - Define several functions as static
 - Move proto_reg_handoff...() to the end of the file
 - Fix whitespace (including "4 space tabs")
 - ...

svn path=/trunk/; revision=43129

1 files changed, 15 insertions, 2 deletions

diff --git a/epan/dissectors/packet-uaudp.h b/epan/dissectors/packet-uaudp.h
index fb05171dab..3dd9a481f7 100644
--- a/epan/dissectors/packet-uaudp.h
+++ b/epan/dissectors/packet-uaudp.h
@@ -26,8 +26,6 @@
 #ifndef _PACKET_UAUDP_H_
 #define _PACKET_UAUDP_H_
 
-#include <gmodule.h>
-
 #define UAUDP_CONNECT           0
 #define UAUDP_CONNECT_ACK       1
 #define UAUDP_RELEASE           2
@@ -37,6 +35,21 @@
 #define UAUDP_NACK              6
 #define UAUDP_DATA              7
 
+#define UAUDP_CONNECT_VERSION           0x00
+#define UAUDP_CONNECT_WINDOW_SIZE       0x01
+#define UAUDP_CONNECT_MTU               0x02
+#define UAUDP_CONNECT_UDP_LOST          0x03
+#define UAUDP_CONNECT_UDP_LOST_REINIT   0x04
+#define UAUDP_CONNECT_KEEPALIVE         0x05
+#define UAUDP_CONNECT_QOS_IP_TOS        0x06
+#define UAUDP_CONNECT_QOS_8021_VLID     0x07
+#define UAUDP_CONNECT_QOS_8021_PRI      0x08
+
+extern value_string_ext uaudp_opcode_str_ext;
+#if 0
+extern value_string_ext uaudp_connect_vals_ext;
+#endif
+
 typedef enum _e_ua_direction {
 	SYS_TO_TERM,  /* system -> terminal */
 	TERM_TO_SYS,  /* terminal -> system */