From didier gautheron: remove redundant or use faster col_xxx functions

- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster.
- same for  replace col_append_fstr and col_append_str
- remove col_clear() when it's redundant:
    + before a col_set/col_add if the dissector can't throw an exception.
- replace col_append() after a col_clear() with faster col_add... or col_set

   https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344


svn path=/trunk/; revision=52948

1 files changed, 2 insertions, 2 deletions

diff --git a/epan/dissectors/packet-ua3g.c b/epan/dissectors/packet-ua3g.c
index 8a32565dd4..346bd7952d 100644
--- a/epan/dissectors/packet-ua3g.c
+++ b/epan/dissectors/packet-ua3g.c
@@ -2203,7 +2203,7 @@ decode_beep(proto_tree *tree, tvbuff_t *tvb, packet_info *pinfo,
         }
     } else { /* Classical Beep */
         /* add text to the frame "INFO" column */
-        col_append_fstr(pinfo->cinfo, COL_INFO, ": Classical Beep");
+        col_append_str(pinfo->cinfo, COL_INFO, ": Classical Beep");
     }
 }
 
@@ -3706,7 +3706,7 @@ dissect_ua3g(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data)
     length = tvb_get_letohs(tvb, offset);
 
     /* add text to the frame "INFO" column */
-    col_append_fstr(pinfo->cinfo, COL_INFO, " - UA3G Message:");
+    col_append_str(pinfo->cinfo, COL_INFO, " - UA3G Message:");
 
     proto_tree_add_uint(ua3g_tree, hf_ua3g_length, tvb, offset, 2, length);
     offset += 2;