diff options
| author | Chris Maynard <Christopher.Maynard@GTECH.COM> | 2011-04-01 18:16:47 +0000 |
|---|---|---|
| committer | Chris Maynard <Christopher.Maynard@GTECH.COM> | 2011-04-01 18:16:47 +0000 |
| commit | 4233a227eff893efa22ac2439006a957feaf011c (patch) | |
| tree | 91b859688871c7fc1a5bf166f68d30c1ec8a8cfd /epan/dissectors/packet-tpncp.c | |
| parent | c236db55fe6da4a6824d02d8eda55ba7ad7f6574 (diff) | |
Avoid potential buffer overruns when sscanf'ing strings.
Should resolve CID's 656 and 657.
svn path=/trunk/; revision=36432
Diffstat (limited to 'epan/dissectors/packet-tpncp.c')
| -rw-r--r-- | epan/dissectors/packet-tpncp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/dissectors/packet-tpncp.c b/epan/dissectors/packet-tpncp.c index b324772aa3..50f88573cb 100644 --- a/epan/dissectors/packet-tpncp.c +++ b/epan/dissectors/packet-tpncp.c @@ -357,7 +357,7 @@ static gint fill_tpncp_id_vals(value_string string[], FILE *file) { if (!strncmp(line_in_file, "#####", 5)) { break; } - if (sscanf(line_in_file, "%s %d", tpncp_name, &tpncp_id) == 2) { + if (sscanf(line_in_file, "%255s %d", tpncp_name, &tpncp_id) == 2) { string[i].strptr = g_strdup(tpncp_name); string[i].value = tpncp_id; if (i < (MAX_TPNCP_DB_SIZE-1)) { @@ -392,7 +392,7 @@ static gint fill_enums_id_vals(FILE *file) { if (!strncmp(line_in_file, "#####", 5)) { break; } - if (sscanf(line_in_file, "%s %s %d", enum_name, enum_str, &enum_id) == 3) { + if (sscanf(line_in_file, "%255s %255s %d", enum_name, enum_str, &enum_id) == 3) { if (strcmp(enum_type, enum_name)) { if (!first_entry) { tpncp_enums_id_vals[enum_val][i].strptr = NULL; |