Require dissectors for all ONC RPC calls and replies.

Either there's a known body for the call or reply, in which case we
already have a dissector for it, or the body is empty, in which case we
now have dissect_rpc_void() to dissect it, or the body is unknown or
nobody's bothered writing it, in which case we use dissect_rpc_unknown()
for now.

This means that an attempt to look up the dissector for a known
procedure will always succeed, so we can label it with the name rather
than with "proc-N".

It also means that we distinguish between "it's void" and "it's
unknown", so that unknown values will get flagged as such.

Change-Id: I748580c1dca61d1f0972396db1a3b0885fc0a541
Reviewed-on: https://code.wireshark.org/review/9699
Reviewed-by: Guy Harris <guy@alum.mit.edu>

1 files changed, 12 insertions, 12 deletions

diff --git a/epan/dissectors/packet-teklink.c b/epan/dissectors/packet-teklink.c
index 79767150b5..fdf141404c 100644
--- a/epan/dissectors/packet-teklink.c
+++ b/epan/dissectors/packet-teklink.c
@@ -411,19 +411,19 @@ static int dissect_teklink_vtl_zmode(tvbuff_t *tvb, packet_info *pinfo _U_,
 static const vsff teklink_proc[] = {
 	{ 1, "TLAFrameOpen", dissect_teklink_tlaframeopen_call, dissect_teklink_tlaframeopen_reply },
 	{ 2, "TLAFrameClose", dissect_teklink_tlaframeclose_call, dissect_teklink_tlaframeclose_reply },
-	{ 3, "GetSoftwareVersion", NULL, dissect_teklink_get_software_version_reply },
+	{ 3, "GetSoftwareVersion", dissect_rpc_void, dissect_teklink_get_software_version_reply },
 	{ 4, "GetInfo", dissect_teklink_info_call, dissect_teklink_info_reply },
-	{ 5, "VtcIdent", NULL, dissect_teklink_vtc_ident },
-	{ 7, "VtcOutEn", dissect_teklink_vtc_outen, NULL },
-	{ 8, "VtcMap", dissect_teklink_vtc_map, NULL },
-	{ 9, "VtcOutSetup", dissect_teklink_vtc_outsetup, NULL },
-	{ 10, "VtcClk", dissect_teklink_vtc_clk, NULL },
-	{ 11, "VtcMode", dissect_teklink_vtc_mode, NULL },
-	{ 12, "VtcRes", dissect_teklink_vtc_res, NULL },
-	{ 13, "VtcHardRes", NULL, NULL },
-	{ 14, "VtcSigStatAll", NULL, dissect_teklink_vtc_sigstatall },
-	{ 20, "VtlZMode", NULL, dissect_teklink_vtl_zmode },
-	{ 21, "VtlSpinBits", NULL, dissect_teklink_vtl_spinbits },
+	{ 5, "VtcIdent", dissect_rpc_void, dissect_teklink_vtc_ident },
+	{ 7, "VtcOutEn", dissect_teklink_vtc_outen, dissect_rpc_void },
+	{ 8, "VtcMap", dissect_teklink_vtc_map, dissect_rpc_void },
+	{ 9, "VtcOutSetup", dissect_teklink_vtc_outsetup, dissect_rpc_void },
+	{ 10, "VtcClk", dissect_teklink_vtc_clk, dissect_rpc_void },
+	{ 11, "VtcMode", dissect_teklink_vtc_mode, dissect_rpc_void },
+	{ 12, "VtcRes", dissect_teklink_vtc_res, dissect_rpc_void },
+	{ 13, "VtcHardRes", dissect_rpc_void, dissect_rpc_void },
+	{ 14, "VtcSigStatAll", dissect_rpc_void, dissect_teklink_vtc_sigstatall },
+	{ 20, "VtlZMode", dissect_rpc_void, dissect_teklink_vtl_zmode },
+	{ 21, "VtlSpinBits", dissect_rpc_void, dissect_teklink_vtl_spinbits },
 	{ 65, "Unknown (65)", dissect_teklink_call65_call, dissect_teklink_call65_reply },
 	{ 0, NULL, NULL, NULL }
 };