aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-tds.c
diff options
context:
space:
mode:
authorTomasz Moń <desowin@gmail.com>2018-08-16 18:04:07 +0200
committerRoland Knall <rknall@gmail.com>2018-08-16 17:30:22 +0000
commitc18459e66e8e71a8765bb9b8e2b3d2ba61855a3f (patch)
tree6073b85ee31990946b1e3e4f868cbf6220886399 /epan/dissectors/packet-tds.c
parent43a5f0ae5131c8ee1fb14d237578a6f516932c76 (diff)
Fix extcap initialization deadlock
On Windows the code calling extcap worked as follows: 1. Create stdout and stderr pipes with default buffer size 2. Execute extcap redirecting output to the pipes 3. Wait for extcap process to exit 4. Read the data from stdout pipe This resulted in deadlock when the extcap wrote more data than the pipe could buffer. This was especially seen with USBPcap as it is quite normal to have plenty of USB devices connected. Fix the issue by contantly reading the stdout data and storing it in GString. To prevent similar deadlock on the stderr, the stderr data is being constantly monitored as well (and discarded). Change-Id: I0f93e6d79617cef0e828aef2b96fad2757227923 Bug: 14657 Reviewed-on: https://code.wireshark.org/review/29159 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-tds.c')
0 files changed, 0 insertions, 0 deletions