diff options
| author | Jeff Morriss <jeff.morriss@ulticom.com> | 2011-01-05 15:18:54 +0000 |
|---|---|---|
| committer | Jeff Morriss <jeff.morriss@ulticom.com> | 2011-01-05 15:18:54 +0000 |
| commit | 5efa40982a47b1b057faa813850d9571602cd308 (patch) | |
| tree | 0ef59bbbbdda5b07f49a64091059d99f789425d6 /epan/dissectors/packet-sua.c | |
| parent | d74bd3ce42a1e4ba86d7dd7ee4df85807330619d (diff) | |
Don't pass the result of tvb_get_ptr() into a %s format string: the string may
not be NULL terminated. Use tvb_get_ephemeral_string() instead.
svn path=/trunk/; revision=35376
Diffstat (limited to 'epan/dissectors/packet-sua.c')
| -rw-r--r-- | epan/dissectors/packet-sua.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/dissectors/packet-sua.c b/epan/dissectors/packet-sua.c index d5772040dc..8d6868853b 100644 --- a/epan/dissectors/packet-sua.c +++ b/epan/dissectors/packet-sua.c @@ -404,7 +404,7 @@ dissect_info_string_parameter(tvbuff_t *parameter_tvb, proto_tree *parameter_tre info_string_length = tvb_get_ntohs(parameter_tvb, PARAMETER_LENGTH_OFFSET) - PARAMETER_HEADER_LENGTH; proto_tree_add_item(parameter_tree, hf_info_string, parameter_tvb, INFO_STRING_OFFSET, info_string_length, ENC_BIG_ENDIAN); proto_item_append_text(parameter_item, " (%.*s)", info_string_length, - (const char *)tvb_get_ptr(parameter_tvb, INFO_STRING_OFFSET, info_string_length)); + tvb_get_ephemeral_string(parameter_tvb, INFO_STRING_OFFSET, info_string_length)); } #define ROUTING_CONTEXT_LENGTH 4 @@ -1317,7 +1317,7 @@ dissect_hostname_parameter(tvbuff_t *parameter_tvb, proto_tree *parameter_tree, hostname_length = tvb_get_ntohs(parameter_tvb, PARAMETER_LENGTH_OFFSET) - PARAMETER_HEADER_LENGTH; proto_tree_add_item(parameter_tree, hf_hostname, parameter_tvb, HOSTNAME_OFFSET, hostname_length, ENC_BIG_ENDIAN); proto_item_append_text(parameter_item, " (%.*s)", hostname_length, - (const char *)tvb_get_ptr(parameter_tvb, HOSTNAME_OFFSET, hostname_length)); + tvb_get_ephemeral_string(parameter_tvb, HOSTNAME_OFFSET, hostname_length)); } #define IPV6_ADDRESS_LENGTH 16 |