diff options
| author | Jakub Zawadzki <darkjames@darkjames.pl> | 2014-05-14 01:56:23 +0200 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2014-05-17 21:33:26 +0000 |
| commit | ea95c837fe62cb89ae7a0507e3ca437b822d658c (patch) | |
| tree | 4474e48708ed60c27eb35d4ee3904381086daed7 /epan/dissectors/packet-stun.c | |
| parent | 24082972a3650c0e743776b47549a17ab0ad20fe (diff) | |
Introduce col_add_lstr(), use it instead of slower col_add_fstr.
We have callgrind benchmarks which shows that col_add_fstr() takes
5% of Ir count cause of formatting done in g_vsnprintf().
New col_add_lstr() can be used in few dissectors without much ugliness,
and it should be a little faster.
Change-Id: Ifddd951063dfd3a27c2a7da4dafce9b242c0472c
Reviewed-on: https://code.wireshark.org/review/1629
Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-stun.c')
| -rw-r--r-- | epan/dissectors/packet-stun.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/epan/dissectors/packet-stun.c b/epan/dissectors/packet-stun.c index 8721716eeb..f539b85027 100644 --- a/epan/dissectors/packet-stun.c +++ b/epan/dissectors/packet-stun.c @@ -541,8 +541,11 @@ dissect_stun_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, gboole msg_class_str = val_to_str_const(msg_type_class, classes, "Unknown"); msg_method_str = val_to_str_const(msg_type_method, methods, "Unknown"); - col_add_fstr(pinfo->cinfo, COL_INFO, "%s %s", - msg_method_str, msg_class_str); + col_add_lstr(pinfo->cinfo, COL_INFO, + msg_method_str, + " ", + msg_class_str, + COL_ADD_LSTR_TERMINATOR); ti = proto_tree_add_item(tree, proto_stun, tvb, 0, -1, ENC_NA); |