diff options
| author | Jaap Keuter <jaap.keuter@xs4all.nl> | 2008-03-17 07:30:22 +0000 |
|---|---|---|
| committer | Jaap Keuter <jaap.keuter@xs4all.nl> | 2008-03-17 07:30:22 +0000 |
| commit | 9f82b154483dbfcc2849cd4aa3b1043d15590ec9 (patch) | |
| tree | ef0c7c58b39490e55b7d3eeeffd7afc487574a33 /epan/dissectors/packet-smpp.c | |
| parent | 98522a39a9aeda22b7f68d7c9768b176eb94fba8 (diff) | |
From Abhik Sarkar:
The attached patch changes the handling of the parameters in question to octet
string instead of string
svn path=/trunk/; revision=24662
Diffstat (limited to 'epan/dissectors/packet-smpp.c')
| -rw-r--r-- | epan/dissectors/packet-smpp.c | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/epan/dissectors/packet-smpp.c b/epan/dissectors/packet-smpp.c index 88b8144e6d..5dc2151f3f 100644 --- a/epan/dissectors/packet-smpp.c +++ b/epan/dissectors/packet-smpp.c @@ -1107,12 +1107,18 @@ smpp_handle_tlv(proto_tree *tree, tvbuff_t *tvb, int *offset) hf_smpp_privacy_indicator, offset); break; case 0x0202: /* source_subaddress */ - smpp_handle_string(sub_tree, tvb, - hf_smpp_source_subaddress, offset); + if (length) { + proto_tree_add_item(sub_tree, hf_smpp_source_subaddress, + tvb, *offset, length, FALSE); + (*offset) += length; + } break; case 0x0203: /* dest_subaddress */ - smpp_handle_string(sub_tree, tvb, - hf_smpp_dest_subaddress, offset); + if (length) { + proto_tree_add_item(sub_tree, hf_smpp_dest_subaddress, + tvb, *offset, length, FALSE); + (*offset) += length; + } break; case 0x0204: /* user_message_reference */ smpp_handle_int2(sub_tree, tvb, @@ -2462,14 +2468,14 @@ proto_register_smpp(void) }, { &hf_smpp_source_subaddress, { "Source Subaddress", "smpp.source_subaddress", - FT_STRING, BASE_NONE, NULL, 0x00, + FT_BYTES, BASE_HEX, NULL, 0x00, "Source Subaddress", HFILL } }, { &hf_smpp_dest_subaddress, { "Destination Subaddress", "smpp.dest_subaddress", - FT_STRING, BASE_NONE, NULL, 0x00, + FT_BYTES, BASE_HEX, NULL, 0x00, "Destination Subaddress", HFILL } |