aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-smb.c
diff options
context:
space:
mode:
authorguy <guy@f5534014-38df-0310-8fa8-9805f1628bb7>2010-06-17 21:41:03 +0000
committerguy <guy@f5534014-38df-0310-8fa8-9805f1628bb7>2010-06-17 21:41:03 +0000
commita443990704908b591adc0a085e29b545c65efd3a (patch)
tree4937b4c547ab3cb0443c5d023c0e6a5438dc0c11 /epan/dissectors/packet-smb.c
parentf1d2bfa40c237bee0c7b0ff2ef296518c8536dfe (diff)
Expand some comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33248 f5534014-38df-0310-8fa8-9805f1628bb7
Diffstat (limited to 'epan/dissectors/packet-smb.c')
-rw-r--r--epan/dissectors/packet-smb.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/epan/dissectors/packet-smb.c b/epan/dissectors/packet-smb.c
index 4fba707bb8..44275f1498 100644
--- a/epan/dissectors/packet-smb.c
+++ b/epan/dissectors/packet-smb.c
@@ -6482,6 +6482,9 @@ dissect_read_andx_response(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
offset += 2;
/*
+ * XXX - the SNIA SMB spec says this is a USHORT, not a
+ * ULONG.
+ *
* XXX - we should really only do this in case we have seen
* LARGE FILE being negotiated. Unfortunately, we might not
* have seen the negotiation phase in the capture....
@@ -6641,7 +6644,11 @@ dissect_write_andx_request(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
proto_tree_add_item(tree, hf_smb_remaining, tvb, offset, 2, TRUE);
offset += 2;
- /* XXX we should really only do this in case we have seen LARGE FILE being negotiated */
+ /*
+ * XXX - we should really only do this in case we have seen
+ * LARGE FILE being negotiated. Unfortunately, we might not
+ * have seen the negotiation phase in the capture....
+ */
/* data length high */
datalen_high = tvb_get_letohs(tvb, offset);
proto_tree_add_uint(tree, hf_smb_data_len_high, tvb, offset, 2, datalen_high);