diff options
| author | guy <guy@f5534014-38df-0310-8fa8-9805f1628bb7> | 2008-05-29 16:51:49 +0000 |
|---|---|---|
| committer | guy <guy@f5534014-38df-0310-8fa8-9805f1628bb7> | 2008-05-29 16:51:49 +0000 |
| commit | 6477e481d4056753f703d0565cc7d87a78c13846 (patch) | |
| tree | 4f6e7d277dbe5f2325836c0435a62eabcea8dd9d /epan/dissectors/packet-smb.c | |
| parent | d21f025c286e36f4646e2e23abc77bd3776b8c4d (diff) | |
Note underflow/overflow possibilities (there used to be checks that
clamped at TIME_T_MIN and TIME_T_MAX, but newer versions of GCC
"helpfully" warn that the usual checks for overflow or underflow "can't
fail").
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25391 f5534014-38df-0310-8fa8-9805f1628bb7
Diffstat (limited to 'epan/dissectors/packet-smb.c')
| -rw-r--r-- | epan/dissectors/packet-smb.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/epan/dissectors/packet-smb.c b/epan/dissectors/packet-smb.c index 3d2b7bf923..badd715763 100644 --- a/epan/dissectors/packet-smb.c +++ b/epan/dissectors/packet-smb.c @@ -1229,8 +1229,10 @@ TimeZoneFaster(time_t t) /* no entry will cover more than 6 months */ low = t - MAX_DST_WIDTH/2; + /* XXX - what if t < MAX_DST_WIDTH/2? */ high = t + MAX_DST_WIDTH/2; + /* XXX - what if this overflows? */ /* * Widen the new entry using two bisection searches. |