diff options
| author | Bill Meier <wmeier@newsguy.com> | 2014-12-24 10:44:03 -0500 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2014-12-26 20:55:25 +0000 |
| commit | b68fb9b659b0debd7286195f9ad194be998cc3ff (patch) | |
| tree | 6567357b78b917f85d50fe1842f864b0dc904e99 /epan/dissectors/packet-smb-sidsnooping.c | |
| parent | 4cf6583b9e5bc7fa5d6f6ac17cdc1f634ae1567e (diff) | |
Fix some dissectors doing termio (fprintf(stderr,..), g_warning()).
- Use report_...failure() (in most cases).
- Also: Do some misc fixes in certain disectors
- re-arrange order of #includes
- Fixup preferences help text
Change-Id: I385f6f97257f365f53ce611df02f57f9257dc5f9
Reviewed-on: https://code.wireshark.org/review/6039
Petri-Dish: Bill Meier <wmeier@newsguy.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'epan/dissectors/packet-smb-sidsnooping.c')
| -rw-r--r-- | epan/dissectors/packet-smb-sidsnooping.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/epan/dissectors/packet-smb-sidsnooping.c b/epan/dissectors/packet-smb-sidsnooping.c index 33a573192d..fdcade96bc 100644 --- a/epan/dissectors/packet-smb-sidsnooping.c +++ b/epan/dissectors/packet-smb-sidsnooping.c @@ -28,6 +28,7 @@ #include <epan/packet.h> #include <epan/epan_dissect.h> #include <epan/tap.h> +#include <wsutil/report_err.h> #include "packet-dcerpc.h" #include "packet-dcerpc-nt.h" #include "packet-smb.h" @@ -348,7 +349,7 @@ sid_snooping_init(void) disabling it now so that it won't cause wireshark to abort due to unknown hf fields */ -sid_name_snooping=0; +sid_name_snooping=FALSE; if(!sid_name_snooping){ return; @@ -380,7 +381,7 @@ sid_name_snooping=0; if(error_string){ /* error, we failed to attach to the tap. clean up */ - fprintf(stderr, "tshark: Couldn't register proto_reg_handoff_smb_sidsnooping()/lsa_policy_information tap: %s\n", + report_failure( "Couldn't register proto_reg_handoff_smb_sidsnooping()/lsa_policy_information tap: %s\n", error_string->str); g_string_free(error_string, TRUE); return; @@ -394,7 +395,7 @@ sid_name_snooping=0; if(error_string){ /* error, we failed to attach to the tap. clean up */ - fprintf(stderr, "tshark: Couldn't register proto_reg_handoff_smb_sidsnooping()/samr_query_dispinfo tap: %s\n", + report_failure( "Couldn't register proto_reg_handoff_smb_sidsnooping()/samr_query_dispinfo tap: %s\n", error_string->str); g_string_free(error_string, TRUE); return; |