aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-smb-browse.c
diff options
context:
space:
mode:
authorMichael Mann <mmann78@netscape.net>2013-09-15 01:48:30 +0000
committerMichael Mann <mmann78@netscape.net>2013-09-15 01:48:30 +0000
commitb38ee917b1953104c615056481d6df008ae94b53 (patch)
tree55024f9c53f083dc056540b6d887fc4550064008 /epan/dissectors/packet-smb-browse.c
parenta17cf67635c6e190c174bc131707804edca5c8f4 (diff)
Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly.
The script didn't catch as many as I would have liked, but it's a start. The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum. svn path=/trunk/; revision=52045
Diffstat (limited to 'epan/dissectors/packet-smb-browse.c')
-rw-r--r--epan/dissectors/packet-smb-browse.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/epan/dissectors/packet-smb-browse.c b/epan/dissectors/packet-smb-browse.c
index 251bba9f5a..a9e0ee0ed8 100644
--- a/epan/dissectors/packet-smb-browse.c
+++ b/epan/dissectors/packet-smb-browse.c
@@ -612,9 +612,9 @@ dissect_mailslot_browse(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tr
/* periodicity (in milliseconds) */
periodicity = tvb_get_letohl(tvb, offset);
- proto_tree_add_uint_format(tree, hf_periodicity, tvb, offset, 4,
+ proto_tree_add_uint_format_value(tree, hf_periodicity, tvb, offset, 4,
periodicity,
- "Update Periodicity: %s",
+ "%s",
time_msecs_to_str(periodicity));
offset += 4;
@@ -719,9 +719,9 @@ dissect_mailslot_browse(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tr
/* server uptime */
uptime = tvb_get_letohl(tvb, offset);
- proto_tree_add_uint_format(tree, hf_server_uptime,
+ proto_tree_add_uint_format_value(tree, hf_server_uptime,
tvb, offset, 4, uptime,
- "Uptime: %s",
+ "%s",
time_msecs_to_str(uptime));
offset += 4;
@@ -879,9 +879,9 @@ dissect_mailslot_lanman(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tr
/* periodicity (in seconds; convert to milliseconds) */
periodicity = tvb_get_letohs(tvb, offset)*1000;
- proto_tree_add_uint_format(tree, hf_periodicity, tvb, offset, 2,
+ proto_tree_add_uint_format_value(tree, hf_periodicity, tvb, offset, 2,
periodicity,
- "Update Periodicity: %s",
+ "%s",
time_msecs_to_str(periodicity));
offset += 2;