diff options
| author | Michael Mann <mmann78@netscape.net> | 2016-12-16 20:06:11 -0500 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-12-31 07:31:42 +0000 |
| commit | f4b0abc7296bbb431e64e31f85b24c29196c2ae4 (patch) | |
| tree | 68394f5fdfa1987900f0b079d0ecfd34003e8a5a /epan/dissectors/packet-sita.c | |
| parent | 13964595ad09e5d1115f6c5cb604cded27f9f55d (diff) | |
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-sita.c')
| -rw-r--r-- | epan/dissectors/packet-sita.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/epan/dissectors/packet-sita.c b/epan/dissectors/packet-sita.c index 67466ea6d8..e59e34a67c 100644 --- a/epan/dissectors/packet-sita.c +++ b/epan/dissectors/packet-sita.c @@ -67,6 +67,8 @@ static int hf_rts = -1; static int hf_dcd = -1; static int hf_signals = -1; +static dissector_handle_t sita_handle; + #define MAX_FLAGS_LEN 64 /* max size of a 'flags' decoded string */ #define IOP "Local" #define REMOTE "Remote" @@ -393,7 +395,7 @@ proto_register_sita(void) sita_dissector_table = register_dissector_table("sita.proto", "SITA protocol number", proto_sita, FT_UINT8, BASE_HEX); proto_register_field_array(proto_sita, hf, array_length(hf)); proto_register_subtree_array(ett, array_length(ett)); - register_dissector("sita", dissect_sita, proto_sita); + sita_handle = register_dissector("sita", dissect_sita, proto_sita); } void @@ -403,13 +405,11 @@ proto_reg_handoff_sita(void) dissector_handle_t frame_relay_handle; dissector_handle_t uts_handle; dissector_handle_t ipars_handle; - dissector_handle_t sita_handle; lapb_handle = find_dissector("lapb"); frame_relay_handle = find_dissector("fr"); uts_handle = find_dissector("uts"); ipars_handle = find_dissector("ipars"); - sita_handle = find_dissector("sita"); dissector_add_uint("sita.proto", SITA_PROTO_BOP_LAPB, lapb_handle); dissector_add_uint("sita.proto", SITA_PROTO_BOP_FRL, frame_relay_handle); |