diff options
| author | Michael Mann <mmann78@netscape.net> | 2016-12-16 20:06:11 -0500 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-12-31 07:31:42 +0000 |
| commit | f4b0abc7296bbb431e64e31f85b24c29196c2ae4 (patch) | |
| tree | 68394f5fdfa1987900f0b079d0ecfd34003e8a5a /epan/dissectors/packet-sgsap.c | |
| parent | 13964595ad09e5d1115f6c5cb604cded27f9f55d (diff) | |
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-sgsap.c')
| -rw-r--r-- | epan/dissectors/packet-sgsap.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/epan/dissectors/packet-sgsap.c b/epan/dissectors/packet-sgsap.c index af63afcdcc..0b3e300869 100644 --- a/epan/dissectors/packet-sgsap.c +++ b/epan/dissectors/packet-sgsap.c @@ -78,6 +78,8 @@ static int ett_sgsap_sel_cs_dmn_op = -1; static expert_field ei_sgsap_extraneous_data = EI_INIT; static expert_field ei_sgsap_missing_mandatory_element = EI_INIT; +static dissector_handle_t sgsap_handle; + static void get_sgsap_msg_params(guint8 oct, const gchar **msg_str, int *ett_tree, int *hf_idx, msg_fcn *msg_fcn_p); /* @@ -1708,7 +1710,7 @@ void proto_register_sgsap(void) { expert_register_field_array(expert_sgsap, ei, array_length(ei)); /* Register dissector */ - register_dissector(PFNAME, dissect_sgsap, proto_sgsap); + sgsap_handle = register_dissector(PFNAME, dissect_sgsap, proto_sgsap); /* Set default SCTP ports */ range_convert_str(&global_sgsap_port_range, SGSAP_SCTP_PORT_RANGE, MAX_SCTP_PORT); @@ -1729,10 +1731,8 @@ proto_reg_handoff_sgsap(void) * The payload protocol identifier to be used for SGsAP is 0. */ static gboolean Initialized = FALSE; - static dissector_handle_t sgsap_handle; static range_t *sgsap_port_range; - sgsap_handle = find_dissector("sgsap"); gsm_a_dtap_handle = find_dissector_add_dependency("gsm_a_dtap", proto_sgsap); if (!Initialized) { |