diff options
| author | Guy Harris <guy@alum.mit.edu> | 2018-12-26 18:26:24 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2018-12-27 04:34:29 +0000 |
| commit | 7eb3e47fa49806ea2cf59f0fa009240fae049a2b (patch) | |
| tree | d668ff9ceae57934fe33582457fc5169f6e764ba /epan/dissectors/packet-sdp.c | |
| parent | c3a7986b86f5355e6bd1791f70b78c91bcdac247 (diff) | |
Try to squeeze some bytes out of the frame_data structure.
Make the time stamp precision a 4-bit bitfield, so, when combined with
the other bitfields, we have 32 bits. That means we put the flags at
the same structure level as the time stamp precision, so they can be
combined; that gets rid of an extra "flags." for references to the flags.
Put the two pointers next to each other, and after a multiple of 8 bytes
worth of other fields, so that there's no padding before or between them.
It's still not down to 64 bytes, which is the next lower power of 2, so
there's more work to do.
Change-Id: I6f3e9d9f6f48137bbee8f100c152d2c42adb8fbe
Reviewed-on: https://code.wireshark.org/review/31213
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'epan/dissectors/packet-sdp.c')
| -rw-r--r-- | epan/dissectors/packet-sdp.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/epan/dissectors/packet-sdp.c b/epan/dissectors/packet-sdp.c index 9c0715f263..9ee3ea794f 100644 --- a/epan/dissectors/packet-sdp.c +++ b/epan/dissectors/packet-sdp.c @@ -2347,7 +2347,7 @@ setup_sdp_transport(tvbuff_t *tvb, packet_info *pinfo, enum sdp_exchange_type ex DPRINT2(("-------------------- setup_sdp_transport -------------------")); /* Only do this once during first pass */ - if (pinfo->fd->flags.visited) { + if (pinfo->fd->visited) { DPRINT(("already visited")); return; } @@ -2543,7 +2543,7 @@ dissect_sdp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data) memset(&sdp_data, 0, sizeof(sdp_data)); - if (!pinfo->fd->flags.visited) { + if (!pinfo->fd->visited) { transport_info = (transport_info_t*)wmem_tree_lookup32( sdp_transport_reqs, pinfo->num ); if (transport_info == NULL) { @@ -2751,7 +2751,7 @@ dissect_sdp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data) /* For messages not part of the Offer/Answer model, assume that the SDP is * immediately effective (apply it now). */ - if ((!pinfo->fd->flags.visited) && (transport_info == &local_transport_info)) { + if ((!pinfo->fd->visited) && (transport_info == &local_transport_info)) { /* XXX - This is a placeholder for higher layer protocols that haven't implemented the proper * OFFER/ANSWER functionality using setup_sdp_transport(). Once all of the higher layers * use setup_sdp_transport(), this should be removed |