diff options
author | Michael Mann <mmann78@netscape.net> | 2016-12-16 20:06:11 -0500 |
---|---|---|
committer | Anders Broman <a.broman58@gmail.com> | 2016-12-31 07:31:42 +0000 |
commit | f4b0abc7296bbb431e64e31f85b24c29196c2ae4 (patch) | |
tree | 68394f5fdfa1987900f0b079d0ecfd34003e8a5a /epan/dissectors/packet-sdh.c | |
parent | 13964595ad09e5d1115f6c5cb604cded27f9f55d (diff) |
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-sdh.c')
-rw-r--r-- | epan/dissectors/packet-sdh.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/epan/dissectors/packet-sdh.c b/epan/dissectors/packet-sdh.c index 5604c5182b..0c35c243cc 100644 --- a/epan/dissectors/packet-sdh.c +++ b/epan/dissectors/packet-sdh.c @@ -68,6 +68,8 @@ static int hf_sdh_h1 = -1; static int hf_sdh_h2 = -1; static int hf_sdh_j1 = -1; +static dissector_handle_t sdh_handle; + static gint sdh_data_rate = 1; static const enum_val_t data_rates[] = { @@ -277,15 +279,12 @@ proto_register_sdh(void) "Data rate", &sdh_data_rate, data_rates, ENC_BIG_ENDIAN); - register_dissector("sdh", dissect_sdh, proto_sdh); + sdh_handle = register_dissector("sdh", dissect_sdh, proto_sdh); } void proto_reg_handoff_sdh(void) { - dissector_handle_t sdh_handle; - - sdh_handle = find_dissector("sdh"); dissector_add_uint("wtap_encap", WTAP_ENCAP_SDH, sdh_handle); } |