diff options
| author | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2019-08-06 13:04:29 +0000 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2019-08-07 04:05:49 +0000 |
| commit | 64ff87712f0e3c65650b612494bd81037e557690 (patch) | |
| tree | d63d0d43d74ed3522a185c1fd5a840a39aae7eea /epan/dissectors/packet-s7comm.c | |
| parent | aa3598764e7bb192776916a063f3cd86e27440b4 (diff) | |
s7comm: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: Iddd57361c9e25e13a28fd86531f6195214a52848
Reviewed-on: https://code.wireshark.org/review/34199
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Thomas Wiens <th.wiens@gmx.de>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-s7comm.c')
| -rw-r--r-- | epan/dissectors/packet-s7comm.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/epan/dissectors/packet-s7comm.c b/epan/dissectors/packet-s7comm.c index 466160a589..70f8c228a9 100644 --- a/epan/dissectors/packet-s7comm.c +++ b/epan/dissectors/packet-s7comm.c @@ -4157,7 +4157,6 @@ s7comm_decode_ud_tis_param(tvbuff_t *tvb, proto_tree_add_item(tp_tree, hf_s7comm_tis_register_db1_nr, tvb, offset, 2, ENC_BIG_ENDIAN); offset += 2; proto_tree_add_item(tp_tree, hf_s7comm_tis_register_db2_nr, tvb, offset, 2, ENC_BIG_ENDIAN); - offset += 2; } else { proto_tree_add_item(tp_tree, hf_s7comm_tis_p_callcond_blocktype, tvb, offset, 2, ENC_BIG_ENDIAN); offset += 2; @@ -4165,7 +4164,6 @@ s7comm_decode_ud_tis_param(tvbuff_t *tvb, offset += 2; if (tp_size >= 38) { proto_tree_add_item(tp_tree, hf_s7comm_tis_p_callcond_address, tvb, offset, 2, ENC_BIG_ENDIAN); - offset += 2; } } } @@ -4173,7 +4171,6 @@ s7comm_decode_ud_tis_param(tvbuff_t *tvb, proto_tree_add_item(tp_tree, hf_s7comm_tis_res_param1, tvb, offset, 2, ENC_NA); offset += 2; proto_tree_add_item(tp_tree, hf_s7comm_tis_res_param2, tvb, offset, 2, ENC_NA); - offset += 2; } } /* May be we don't know all values when here, so set offset to the given length */ @@ -4922,7 +4919,6 @@ s7comm_decode_ud_tis_bstack(tvbuff_t *tvb, } else { proto_tree_add_item(item_tree, hf_s7comm_tis_bstack_reserved, tvb, offset, rem, ENC_NA); offset += rem; - rem = 0; break; } } |