diff options
| author | Michael Mann <mmann78@netscape.net> | 2014-09-06 08:44:23 -0400 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2014-09-09 01:25:36 +0000 |
| commit | 80407a46df538011c1dcea96714c401a4078a697 (patch) | |
| tree | f62b063004ba6a8946c552c6a3180cb8f417cd83 /epan/dissectors/packet-rlogin.c | |
| parent | 124923b02f3113a1f2aeae205417a18828671850 (diff) | |
Eliminate proto_tree_add_text from some of the dissectors.
Other minor cleanups while in the area.
Change-Id: I99096ade9c69a4c148962d45bb6b0bd775040ba1
Reviewed-on: https://code.wireshark.org/review/4020
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'epan/dissectors/packet-rlogin.c')
| -rw-r--r-- | epan/dissectors/packet-rlogin.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/epan/dissectors/packet-rlogin.c b/epan/dissectors/packet-rlogin.c index b24112cfa4..d5c157e500 100644 --- a/epan/dissectors/packet-rlogin.c +++ b/epan/dissectors/packet-rlogin.c @@ -58,6 +58,7 @@ static int hf_user_info_server_user_name = -1; static int hf_user_info_terminal_type = -1; static int hf_user_info_terminal_speed = -1; static int hf_control_message = -1; +static int hf_magic_cookie = -1; static int hf_window_info = -1; static int hf_window_info_ss = -1; static int hf_window_info_rows = -1; @@ -334,7 +335,7 @@ static void rlogin_display(rlogin_hash_entry_t *hash_info, window_tree = proto_item_add_subtree(window_info_item, ett_rlogin_window); /* Cookie */ - proto_tree_add_text(window_tree, tvb, offset, 2, "Magic Cookie: (0xff, 0xff)"); + proto_tree_add_item(window_tree, hf_magic_cookie, tvb, offset, 2, ENC_BIG_ENDIAN); offset += 2; /* These bytes should be "ss" */ @@ -531,6 +532,11 @@ void proto_register_rlogin(void) VALS(control_message_vals), 0x0, NULL, HFILL } }, + { &hf_magic_cookie, + { "Magic Cookie", "rlogin.magic_cookie", FT_UINT16, BASE_HEX, + NULL, 0x0, NULL, HFILL + } + }, { &hf_window_info, { "Window Info", "rlogin.window_size", FT_NONE, BASE_NONE, NULL, 0x0, NULL, HFILL |