diff options
author | Michael Mann <mmann78@netscape.net> | 2013-09-15 01:48:30 +0000 |
---|---|---|
committer | Michael Mann <mmann78@netscape.net> | 2013-09-15 01:48:30 +0000 |
commit | b38ee917b1953104c615056481d6df008ae94b53 (patch) | |
tree | 55024f9c53f083dc056540b6d887fc4550064008 /epan/dissectors/packet-pptp.c | |
parent | a17cf67635c6e190c174bc131707804edca5c8f4 (diff) |
Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly.
The script didn't catch as many as I would have liked, but it's a start.
The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum.
svn path=/trunk/; revision=52045
Diffstat (limited to 'epan/dissectors/packet-pptp.c')
-rw-r--r-- | epan/dissectors/packet-pptp.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/epan/dissectors/packet-pptp.c b/epan/dissectors/packet-pptp.c index cfec22a447..606eb4833e 100644 --- a/epan/dissectors/packet-pptp.c +++ b/epan/dissectors/packet-pptp.c @@ -224,8 +224,8 @@ dissect_cntrl_req(tvbuff_t *tvb, int offset, packet_info *pinfo _U_, proto_tree if (!tree) return; - proto_tree_add_uint_format(tree, hf_pptp_protocol_version, tvb, offset, - 2, tvb_get_ntohs(tvb, offset), "Protocol version: %u.%u", + proto_tree_add_uint_format_value(tree, hf_pptp_protocol_version, tvb, offset, + 2, tvb_get_ntohs(tvb, offset), "%u.%u", tvb_get_guint8(tvb, offset), tvb_get_guint8(tvb, offset + 1)); offset += 2; @@ -256,8 +256,8 @@ dissect_cntrl_reply(tvbuff_t *tvb, int offset, packet_info *pinfo _U_, proto_tre if (!tree) return; - proto_tree_add_uint_format(tree, hf_pptp_protocol_version, tvb, offset, - 2, tvb_get_ntohs(tvb, offset), "Protocol version: %u.%u", + proto_tree_add_uint_format_value(tree, hf_pptp_protocol_version, tvb, offset, + 2, tvb_get_ntohs(tvb, offset), "%u.%u", tvb_get_guint8(tvb, offset), tvb_get_guint8(tvb, offset + 1)); offset += 2; |