diff options
| author | Guy Harris <guy@alum.mit.edu> | 2018-03-23 20:33:18 -0700 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2018-03-24 03:33:50 +0000 |
| commit | b4b374937f33368cbf06aaedb7f22448076d47fb (patch) | |
| tree | e0777c29364f596b1c11fefb9ee62e01b8a10fa1 /epan/dissectors/packet-ppp.c | |
| parent | 0f34a866bb29b78a2dbd40583e1e49cec58dcc0e (diff) | |
Fix a comment.
We already *have* an exported dissector that always dissects PPP without
HDLC-like framing; the question is whether we should have one that
always dissects PPP with HDLC-like framing (with a check for the
HDLC-like framing, in case, for example, it was negotiated away), but
doesn't check for Cisco HDLC.
Change-Id: I3b3319dd29c7516220b82df626bc6ac520ea0dd9
Reviewed-on: https://code.wireshark.org/review/26622
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'epan/dissectors/packet-ppp.c')
| -rw-r--r-- | epan/dissectors/packet-ppp.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/epan/dissectors/packet-ppp.c b/epan/dissectors/packet-ppp.c index a2dc8d15f9..66a00ac2a5 100644 --- a/epan/dissectors/packet-ppp.c +++ b/epan/dissectors/packet-ppp.c @@ -5856,8 +5856,9 @@ dissect_ppp_hdlc(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data } /* - * XXX - should we have an exported dissector that always dissects PPP, - * for use when we know the packets are PPP, not CHDLC? + * XXX - should we have an exported dissector that always dissects + * PPP-in-HDLC-like-framing, without checking for Cisco HDLC, for + * use when we know the packets are PPP, not Cisco HDLC? */ col_set_str(pinfo->cinfo, COL_PROTOCOL, "PPP"); switch (pinfo->p2p_dir) { |