diff options
| author | Ulf Lamping <ulf.lamping@web.de> | 2005-03-25 17:24:48 +0000 |
|---|---|---|
| committer | Ulf Lamping <ulf.lamping@web.de> | 2005-03-25 17:24:48 +0000 |
| commit | a52bb15613ec3bf5218e6e9d1eac30137bd968fd (patch) | |
| tree | c8f123449fc113ec3c42e9165080bc32c1344295 /epan/dissectors/packet-ppp.c | |
| parent | c0ce016153ec1ee1ce50bba72b8c276e67d1d5c4 (diff) | |
bugfix: similar problem than the previous one fixed by Gerald
svn path=/trunk/; revision=13898
Diffstat (limited to 'epan/dissectors/packet-ppp.c')
| -rw-r--r-- | epan/dissectors/packet-ppp.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/epan/dissectors/packet-ppp.c b/epan/dissectors/packet-ppp.c index 4bb884d29d..62d45f8e62 100644 --- a/epan/dissectors/packet-ppp.c +++ b/epan/dissectors/packet-ppp.c @@ -2457,7 +2457,8 @@ dissect_bap_phone_delta_opt(const ip_tcp_opt *optp, tvbuff_t *tvb, offset += 2; length -= 2; - while (length > 0) { + /* XXX - Should we check for a maximum length instead of using a cast? */ + while (((gint) length) > 0) { subopt_type = tvb_get_guint8(tvb, offset); subopt_len = tvb_get_guint8(tvb, offset + 1); ti = proto_tree_add_text(field_tree, tvb, offset, subopt_len, |