diff options
| author | Martin Mathieson <martin.mathieson@keysight.com> | 2020-03-31 22:46:55 +0100 |
|---|---|---|
| committer | Martin Mathieson <martin.r.mathieson@googlemail.com> | 2020-04-01 10:32:08 +0000 |
| commit | 71e9009825db727fd84f7cbc9cc278df988188b9 (patch) | |
| tree | 9790df3a5df69b2dd683581253539a1703114026 /epan/dissectors/packet-per.c | |
| parent | 9b7a54d86c197af42c7b9a0a7925b42a637acd3c (diff) | |
Check for true_false_string with identical true/false string.
Fixed a few instances where fix were obvious, others are
less clear.
The check in proto.c is protected by ENABLE_CHECK_FILTER.
Change-Id: I4edee4e67bd53bbf2eb809d68c87983a7c5a66f3
Reviewed-on: https://code.wireshark.org/review/36645
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Diffstat (limited to 'epan/dissectors/packet-per.c')
| -rw-r--r-- | epan/dissectors/packet-per.c | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/epan/dissectors/packet-per.c b/epan/dissectors/packet-per.c index 2d2ef35586..b14db61abd 100644 --- a/epan/dissectors/packet-per.c +++ b/epan/dissectors/packet-per.c @@ -100,10 +100,6 @@ static gboolean display_internal_per_fields = FALSE; -static const true_false_string tfs_extension_present_bit = { - "", - "" -}; static const true_false_string tfs_extension_bit = { "Extension bit is set", "Extension bit is clear" @@ -112,10 +108,6 @@ static const true_false_string tfs_small_number_bit = { "The number is small, 0-63", "The number is large, >63" }; -static const true_false_string tfs_optional_field_bit = { - "", - "" -}; #define BYTE_ALIGN_OFFSET(offset) if(offset&0x07){offset=(offset&0xfffffff8)+8;} @@ -2740,13 +2732,13 @@ proto_register_per(void) TFS(&tfs_extension_bit), 0x01, "The extension bit of an aggregate", HFILL }}, { &hf_per_extension_present_bit, { "Extension Present Bit", "per.extension_present_bit", FT_BOOLEAN, 8, - TFS(&tfs_extension_present_bit), 0x01, "Whether this optional extension is present or not", HFILL }}, + NULL, 0x01, "Whether this optional extension is present or not", HFILL }}, { &hf_per_small_number_bit, { "Small Number Bit", "per.small_number_bit", FT_BOOLEAN, 8, TFS(&tfs_small_number_bit), 0x01, "The small number bit for a section 10.6 integer", HFILL }}, { &hf_per_optional_field_bit, { "Optional Field Bit", "per.optional_field_bit", FT_BOOLEAN, 8, - TFS(&tfs_optional_field_bit), 0x01, "This bit specifies the presence/absence of an optional field", HFILL }}, + NULL, 0x01, "This bit specifies the presence/absence of an optional field", HFILL }}, { &hf_per_sequence_of_length, { "Sequence-Of Length", "per.sequence_of_length", FT_UINT32, BASE_DEC, NULL, 0, "Number of items in the Sequence Of", HFILL }}, |