aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-pdcp-lte.c
diff options
context:
space:
mode:
authorMartin Mathieson <martin.r.mathieson@googlemail.com>2014-05-03 22:36:56 +0100
committerMartin Mathieson <martin.r.mathieson@googlemail.com>2014-05-03 21:38:36 +0000
commit32e3e410ae86016e7039be0424b0085b6ccecbd3 (patch)
tree3a583ff991f1e711cd9e5103ba243fd9754fffb2 /epan/dissectors/packet-pdcp-lte.c
parenta394d448f476ce417ec0f92d625017086c43f694 (diff)
Update TODO comments
Change-Id: I4ea940be5b65c041bdd330bfc2bdbe9a00360d00 Reviewed-on: https://code.wireshark.org/review/1475 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Diffstat (limited to 'epan/dissectors/packet-pdcp-lte.c')
-rw-r--r--epan/dissectors/packet-pdcp-lte.c10
1 files changed, 6 insertions, 4 deletions
diff --git a/epan/dissectors/packet-pdcp-lte.c b/epan/dissectors/packet-pdcp-lte.c
index 96a870f313..e03f6817cb 100644
--- a/epan/dissectors/packet-pdcp-lte.c
+++ b/epan/dissectors/packet-pdcp-lte.c
@@ -42,7 +42,8 @@
Note that the use of this algorithm is restricted, and that an administrative charge
may be applicable if you use it (see e.g. http://www.gsma.com/technicalprojects/fraud-security/security-algorithms).
A version of Wireshark with this enabled would not be distributable. */
-/* #define HAVE_SNOW3G */
+#define HAVE_SNOW3G
+#include <epan/snow3g_algorithm.h>
#include "packet-rlc-lte.h"
#include "packet-pdcp-lte.h"
@@ -57,9 +58,10 @@ void proto_reg_handoff_pdcp_lte(void);
/* TODO:
- - More deciphering. Next steps are:
- - Verify MAC authentication bytes for supported protocol(s)?
- - code that doesn't quite work against gcrypt 1.6 is #if 0'd out...
+ - Decipher even if sequence analysis isn't 'OK'?
+ - know SN, but might be unsure about HFN.
+ - Speed up AES decryption by keeping the crypt handle around for the channel
+ (like ESP decryption in IPSEC dissector)
- Add Relay Node user plane data PDU dissection
*/