diff options
| author | Guy Harris <guy@alum.mit.edu> | 2004-08-18 06:56:36 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2004-08-18 06:56:36 +0000 |
| commit | 09f2fe9191cf27926ee76fe74a543d0642a56e8c (patch) | |
| tree | 47b1e4993498ea65b3a318ed3d1cbe35efe5946c /epan/dissectors/packet-ntlmssp.c | |
| parent | 63579e7bfcbb45981ff251d451893fc7af32daad (diff) | |
Samba's smbclient doesn't put the extra stuff after the list of names in
the NTLMv2 blob, so don't bother dissecting it for now - perhaps we
should see how much of the NTLMv2 response remains, and, if there is
any, put it into the tree as extra data.
svn path=/trunk/; revision=11765
Diffstat (limited to 'epan/dissectors/packet-ntlmssp.c')
| -rw-r--r-- | epan/dissectors/packet-ntlmssp.c | 17 |
1 files changed, 11 insertions, 6 deletions
diff --git a/epan/dissectors/packet-ntlmssp.c b/epan/dissectors/packet-ntlmssp.c index 4cd831dc79..0d631aaf12 100644 --- a/epan/dissectors/packet-ntlmssp.c +++ b/epan/dissectors/packet-ntlmssp.c @@ -720,12 +720,17 @@ dissect_ntlmv2_response(tvbuff_t *tvb, proto_tree *tree, int offset, int len) break; } - proto_tree_add_item( - ntlmv2_tree, hf_ntlmssp_ntlmv2_response_unknown, tvb, - offset, 4, TRUE); - - offset += 4; - + /* + * XXX - Windows puts 4 bytes of additional stuff here. + * Samba's smbclient doesn't. + * Both of them appear to be able to connect to W2K SMB + * servers. + * Should we display the rest of the response as an + * "extra data" item? + * + * XXX - we should also check whether we go past the length + * of the response. + */ return offset; } |