diff options
author | Bill Meier <wmeier@newsguy.com> | 2015-01-23 00:24:46 -0500 |
---|---|---|
committer | Bill Meier <wmeier@newsguy.com> | 2015-01-23 05:30:55 +0000 |
commit | 8d1a9848e3acc266447e1ccc032f377ba559ca50 (patch) | |
tree | a9bcbf39ec065f2ef3e37140abd3ce7b36855e40 /epan/dissectors/packet-netflow.c | |
parent | 5a23a02ab8ae59c451db76bd9304ee420f3e3be5 (diff) |
Remove incorrect 'if (tree)'
Incorrect because of one or both of the following:
- col_...()/expert...() called under 'if (tree)'
- vars set under 'if (tree)' used later (not under 'if (tree)'
as args to col_...()/expert_...()
Change-Id: I89f7d453f2d6eaa40d51cbd794ed2c9be7e549de
Reviewed-on: https://code.wireshark.org/review/6754
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Diffstat (limited to 'epan/dissectors/packet-netflow.c')
-rw-r--r-- | epan/dissectors/packet-netflow.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/epan/dissectors/packet-netflow.c b/epan/dissectors/packet-netflow.c index 3b25058b26..68f8a3a888 100644 --- a/epan/dissectors/packet-netflow.c +++ b/epan/dissectors/packet-netflow.c @@ -2075,14 +2075,12 @@ dissect_netflow(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data offset += 2; pdus = tvb_get_ntohs(tvb, offset); - if (tree) { - if(ver == 10) { - proto_tree_add_uint(netflow_tree, hf_cflow_len, tvb, offset, 2, pdus); - flow_len = pdus; - } else { - proto_tree_add_uint(netflow_tree, hf_cflow_count, tvb, offset, 2, pdus); - flow_len = -1; - } + if(ver == 10) { + proto_tree_add_uint(netflow_tree, hf_cflow_len, tvb, offset, 2, pdus); + flow_len = pdus; + } else { + proto_tree_add_uint(netflow_tree, hf_cflow_count, tvb, offset, 2, pdus); + flow_len = -1; } offset += 2; |