Rename tvb_new_subset() to tvb_new_subset_length_caplen().

This emphasizes that there is no such thing as *the* routine to
construct a subset tvbuff; you need to choose one of
tvb_new_subset_remaining() (if you want a new tvbuff that contains
everything past a certain point in an existing tvbuff),
tvb_new_subset_length() (if you want a subset that contains everything
past a certain point, for some number of bytes, in an existing tvbuff),
and tvb_new_subset_length_caplen() (for all other cases).

Many of the calls to tvb_new_subset_length_caplen() should really be
calling one of the other routines; that's the next step.  (This also
makes it easier to find the calls that need fixing.)

Change-Id: Ieb3d676d8cda535451c119487d7cd3b559221f2b
Reviewed-on: https://code.wireshark.org/review/19597
Reviewed-by: Guy Harris <guy@alum.mit.edu>

1 files changed, 3 insertions, 3 deletions

diff --git a/epan/dissectors/packet-ncp2222.inc b/epan/dissectors/packet-ncp2222.inc
index 63b1754ba4..31a66582fa 100644
--- a/epan/dissectors/packet-ncp2222.inc
+++ b/epan/dissectors/packet-ncp2222.inc
@@ -6949,7 +6949,7 @@ nds_defrag(tvbuff_t *tvb, packet_info *pinfo, guint32 nw_connection, guint8 sequ
                 else
                 {
                     /* This is either a beggining or middle fragment on second dissection */
-                    frag_tvb = tvb_new_subset(tvb, 0, -1, -1);
+                    frag_tvb = tvb_new_subset_length_caplen(tvb, 0, -1, -1);
                     if (request_value->nds_frag)
                     {
                       col_add_fstr(pinfo->cinfo, COL_INFO, "[NDS Fragment 0x%08x]", frags[frag_count].nds_frag);
@@ -6972,12 +6972,12 @@ nds_defrag(tvbuff_t *tvb, packet_info *pinfo, guint32 nw_connection, guint8 sequ
             /*
              * There are no bytes so Dissect this
              */
-            frag_tvb = tvb_new_subset(tvb, 0, -1, -1);
+            frag_tvb = tvb_new_subset_length_caplen(tvb, 0, -1, -1);
         }
         if (frag_tvb == NULL)
         {
             /* This is a fragment packet */
-            frag_tvb = tvb_new_subset (tvb, 0, -1, -1);
+            frag_tvb = tvb_new_subset_length_caplen(tvb, 0, -1, -1);
             nds_data_handle = find_dissector("data");
             call_dissector(nds_data_handle, frag_tvb, pinfo, tree);
         }