diff options
| author | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2021-01-12 09:42:34 +0000 |
|---|---|---|
| committer | AndersBroman <a.broman58@gmail.com> | 2021-02-07 07:32:00 +0000 |
| commit | 60cdc48efd5037f6c847e8b6f4d985eaa3a2c37e (patch) | |
| tree | 0295527251fdda699cbfebf5c1facd143c0e2065 /epan/dissectors/packet-mgcp.c | |
| parent | 7ef0bd34b07f5b3678320f5ec01c27b1a86792f2 (diff) | |
mgcp: fix Dead Store Found by Clang Analyzer
Although the value stored to 'tempchar' is used in the enclosing expression, the value is never actually read from 'tempchar'
Diffstat (limited to 'epan/dissectors/packet-mgcp.c')
| -rw-r--r-- | epan/dissectors/packet-mgcp.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/epan/dissectors/packet-mgcp.c b/epan/dissectors/packet-mgcp.c index 7c6ec82719..f04b0441b1 100644 --- a/epan/dissectors/packet-mgcp.c +++ b/epan/dissectors/packet-mgcp.c @@ -853,18 +853,18 @@ static gint tvb_parse_param(tvbuff_t* tvb, gint offset, gint len, int** hf, mgcp /* XRM/MCR */ else if (len > (tvb_current_offset - offset) && - (tempchar = (guint8)g_ascii_toupper(tvb_get_guint8(tvb,tvb_current_offset))) == 'R') + ((guint8)g_ascii_toupper(tvb_get_guint8(tvb,tvb_current_offset))) == 'R') { /* Move past 'R' */ tvb_current_offset += 3; if (len > (tvb_current_offset - offset) && - (tempchar = (guint8)g_ascii_toupper(tvb_get_guint8(tvb,tvb_current_offset))) == 'R') + ((guint8)g_ascii_toupper(tvb_get_guint8(tvb,tvb_current_offset))) == 'R') { *hf = &hf_mgcp_param_remotevoicemetrics; } else if (len > (tvb_current_offset - offset) && - (tempchar = (guint8)g_ascii_toupper(tvb_get_guint8(tvb,tvb_current_offset))) == 'L') + ((guint8)g_ascii_toupper(tvb_get_guint8(tvb,tvb_current_offset))) == 'L') { *hf = &hf_mgcp_param_localvoicemetrics; } |