diff options
| author | Michael Mann <mmann78@netscape.net> | 2016-12-16 20:06:11 -0500 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-12-31 07:31:42 +0000 |
| commit | f4b0abc7296bbb431e64e31f85b24c29196c2ae4 (patch) | |
| tree | 68394f5fdfa1987900f0b079d0ecfd34003e8a5a /epan/dissectors/packet-lwm.c | |
| parent | 13964595ad09e5d1115f6c5cb604cded27f9f55d (diff) | |
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-lwm.c')
| -rw-r--r-- | epan/dissectors/packet-lwm.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/epan/dissectors/packet-lwm.c b/epan/dissectors/packet-lwm.c index 1bbc38c3de..453416d4cd 100644 --- a/epan/dissectors/packet-lwm.c +++ b/epan/dissectors/packet-lwm.c @@ -149,6 +149,8 @@ static expert_field ei_lwm_empty_payload = EI_INIT; static expert_field ei_lwm_no_decryption_key = EI_INIT; static expert_field ei_lwm_decryption_failed = EI_INIT; +static dissector_handle_t lwm_handle; + static const value_string lwm_cmd_names[] = { { LWM_CMD_ACK, "LwMesh ACK" }, { LWM_CMD_ROUTE_ERR, "Route Error" }, @@ -905,7 +907,7 @@ void proto_register_lwm(void) "128-bit decryption key in hexadecimal format", (const char **)&lwmes_key_str); /* Register dissector with Wireshark. */ - register_dissector("lwm", dissect_lwm, proto_lwm); + lwm_handle = register_dissector("lwm", dissect_lwm, proto_lwm); } /* proto_register_lwm */ @@ -937,7 +939,7 @@ void proto_reg_handoff_lwm(void) /* Register our dissector with IEEE 802.15.4 */ - dissector_add_for_decode_as(IEEE802154_PROTOABBREV_WPAN_PANID, find_dissector("lwm")); + dissector_add_for_decode_as(IEEE802154_PROTOABBREV_WPAN_PANID, lwm_handle); heur_dissector_add(IEEE802154_PROTOABBREV_WPAN, dissect_lwm_heur, "Lightweight Mesh over IEEE 802.15.4", "lwm_wlan", proto_lwm, HEURISTIC_ENABLE); } /* proto_reg_handoff_lwm */ |