diff options
| author | Guy Harris <guy@alum.mit.edu> | 2014-04-09 17:48:32 -0700 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2014-04-10 00:49:01 +0000 |
| commit | 7cbc790832cfb067857b523ef2ad440966ef824a (patch) | |
| tree | 80548526eefac4705f21634bbe6d080a78244f49 /epan/dissectors/packet-lbmc.c | |
| parent | 7fb9e9beb0ce8148747a34ea7ceaa1391c2fa776 (diff) | |
Avoid bug 9962 - don't use variables that haven't been set.
See the comment for details.
Change-Id: I0b1800dd884736e00201f09166c0d2bd6795b6c3
Reviewed-on: https://code.wireshark.org/review/1047
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'epan/dissectors/packet-lbmc.c')
| -rw-r--r-- | epan/dissectors/packet-lbmc.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/epan/dissectors/packet-lbmc.c b/epan/dissectors/packet-lbmc.c index 36b5318d5e..88645377c3 100644 --- a/epan/dissectors/packet-lbmc.c +++ b/epan/dissectors/packet-lbmc.c @@ -11018,7 +11018,11 @@ int lbmc_dissect_lbmc_packet(tvbuff_t * tvb, int offset, packet_info * pinfo, pr COPY_ADDRESS_SHALLOW(&tcp_addr, &(pinfo->dst)); tcp_port = (guint16)pinfo->destport; } - if ((pinfo->fd->flags.visited == 0) && (tcp_sid_info.set) && !lbm_channel_is_known(channel)) + /* XXX - do we need to check lbm_channel_is_unknown_stream_tcp(channel)? + We must *NOT* call lbttcp_transport_sid_add() unless + lbm_channel_is_unknown_transport_lbttcp(channel) is true as, if + it's not true, we will *NOT* have set tcp_addr or tcp_port above! */ + if ((pinfo->fd->flags.visited == 0) && (tcp_sid_info.set) && lbm_channel_is_unknown_transport_lbttcp(channel)) { lbttcp_transport_sid_add(&tcp_addr, tcp_port, pinfo->fd->num, tcp_sid_info.session_id); } |