diff options
author | Michael Mann <mmann78@netscape.net> | 2016-12-16 20:06:11 -0500 |
---|---|---|
committer | Anders Broman <a.broman58@gmail.com> | 2016-12-31 07:31:42 +0000 |
commit | f4b0abc7296bbb431e64e31f85b24c29196c2ae4 (patch) | |
tree | 68394f5fdfa1987900f0b079d0ecfd34003e8a5a /epan/dissectors/packet-iuup.c | |
parent | 13964595ad09e5d1115f6c5cb604cded27f9f55d (diff) |
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-iuup.c')
-rw-r--r-- | epan/dissectors/packet-iuup.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/epan/dissectors/packet-iuup.c b/epan/dissectors/packet-iuup.c index d771094b5d..370be8afbc 100644 --- a/epan/dissectors/packet-iuup.c +++ b/epan/dissectors/packet-iuup.c @@ -157,6 +157,8 @@ static expert_field ei_iuup_pdu_type = EI_INIT; static GHashTable* circuits = NULL; +static dissector_handle_t iuup_handle; + static gboolean dissect_fields = FALSE; static gboolean two_byte_pseudoheader = FALSE; static guint global_dynamic_payload_type = 0; @@ -843,11 +845,9 @@ static void cleanup_iuup(void) { void proto_reg_handoff_iuup(void) { static gboolean iuup_prefs_initialized = FALSE; - static dissector_handle_t iuup_handle; static guint saved_dynamic_payload_type = 0; if (!iuup_prefs_initialized) { - iuup_handle = find_dissector("iuup"); dissector_add_string("rtp_dyn_payload_type","VND.3GPP.IUFP", iuup_handle); iuup_prefs_initialized = TRUE; } else { @@ -994,7 +994,7 @@ void proto_register_iuup(void) { proto_register_subtree_array(ett, array_length(ett)); expert_iuup = expert_register_protocol(proto_iuup); expert_register_field_array(expert_iuup, ei, array_length(ei)); - register_dissector("iuup", dissect_iuup, proto_iuup); + iuup_handle = register_dissector("iuup", dissect_iuup, proto_iuup); register_dissector("find_iuup", find_iuup, proto_iuup); register_init_routine(&init_iuup); |