diff options
author | Michael Mann <mmann78@netscape.net> | 2013-09-15 01:48:30 +0000 |
---|---|---|
committer | Michael Mann <mmann78@netscape.net> | 2013-09-15 01:48:30 +0000 |
commit | b38ee917b1953104c615056481d6df008ae94b53 (patch) | |
tree | 55024f9c53f083dc056540b6d887fc4550064008 /epan/dissectors/packet-ipsi-ctl.c | |
parent | a17cf67635c6e190c174bc131707804edca5c8f4 (diff) |
Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly.
The script didn't catch as many as I would have liked, but it's a start.
The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum.
svn path=/trunk/; revision=52045
Diffstat (limited to 'epan/dissectors/packet-ipsi-ctl.c')
-rw-r--r-- | epan/dissectors/packet-ipsi-ctl.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/epan/dissectors/packet-ipsi-ctl.c b/epan/dissectors/packet-ipsi-ctl.c index ceaf196428..77b9099c40 100644 --- a/epan/dissectors/packet-ipsi-ctl.c +++ b/epan/dissectors/packet-ipsi-ctl.c @@ -117,9 +117,8 @@ static void dissect_ipsictl(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) if (tree) { - ti = proto_tree_add_uint_format(ipsictl_tree, hf_ipsictl_pdu, tvb, - offset, (length+4), pdu, - "PDU: %d", pdu); + ti = proto_tree_add_uint(ipsictl_tree, hf_ipsictl_pdu, tvb, + offset, (length+4), pdu); pdu_tree = proto_item_add_subtree(ti, ett_ipsictl_pdu); } @@ -201,7 +200,7 @@ void proto_register_ipsictl(void) static hf_register_info hf[] = { { &hf_ipsictl_pdu, { "PDU", "ipsictl.pdu", - FT_UINT16, BASE_HEX, NULL, 0x0, + FT_UINT16, BASE_DEC, NULL, 0x0, "IPSICTL PDU", HFILL }}, { &hf_ipsictl_magic, { "Magic", "ipsictl.magic", |