diff options
| author | Bill Meier <wmeier@newsguy.com> | 2013-10-29 14:09:20 +0000 |
|---|---|---|
| committer | Bill Meier <wmeier@newsguy.com> | 2013-10-29 14:09:20 +0000 |
| commit | 0ad98563a24b8685545825aac889ef43bfc58809 (patch) | |
| tree | d44e5d34582bc2a05ba6be6bd8d818e9a813147f /epan/dissectors/packet-igmp.c | |
| parent | 86c145ecb33495023a7966030faab5a69a3067eb (diff) | |
From didier gautheron: remove redundant or use faster col_xxx functions
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster.
- same for replace col_append_fstr and col_append_str
- remove col_clear() when it's redundant:
+ before a col_set/col_add if the dissector can't throw an exception.
- replace col_append() after a col_clear() with faster col_add... or col_set
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344
svn path=/trunk/; revision=52948
Diffstat (limited to 'epan/dissectors/packet-igmp.c')
| -rw-r--r-- | epan/dissectors/packet-igmp.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/epan/dissectors/packet-igmp.c b/epan/dissectors/packet-igmp.c index ff1b230e23..c354e538ba 100644 --- a/epan/dissectors/packet-igmp.c +++ b/epan/dissectors/packet-igmp.c @@ -589,7 +589,7 @@ dissect_igmp_v3_report(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, int /* number of group records */ num = tvb_get_ntohs(tvb, offset); if (!num) - col_append_fstr(pinfo->cinfo, COL_INFO, " - General query"); + col_append_str(pinfo->cinfo, COL_INFO, " - General query"); proto_tree_add_uint(tree, hf_num_grp_recs, tvb, offset, 2, num); offset += 2; @@ -621,7 +621,7 @@ dissect_igmp_v3_query(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, int t maddr = tvb_get_ipv4(tvb, offset); if (! maddr) { - col_append_fstr(pinfo->cinfo, COL_INFO, ", general"); + col_append_str(pinfo->cinfo, COL_INFO, ", general"); } else { col_append_fstr(pinfo->cinfo, COL_INFO, ", specific for group %s", ip_to_str((guint8*)&maddr)); @@ -675,7 +675,7 @@ dissect_igmp_v2(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, int type, i maddr = tvb_get_ipv4(tvb, offset); if (! maddr) { - col_append_fstr(pinfo->cinfo, COL_INFO, ", general"); + col_append_str(pinfo->cinfo, COL_INFO, ", general"); } else { if (type == IGMP_V2_LEAVE_GROUP) { col_append_fstr(pinfo->cinfo, COL_INFO, |