diff options
| author | Bill Meier <wmeier@newsguy.com> | 2013-10-29 14:09:20 +0000 |
|---|---|---|
| committer | Bill Meier <wmeier@newsguy.com> | 2013-10-29 14:09:20 +0000 |
| commit | 0ad98563a24b8685545825aac889ef43bfc58809 (patch) | |
| tree | d44e5d34582bc2a05ba6be6bd8d818e9a813147f /epan/dissectors/packet-ieee80211.c | |
| parent | 86c145ecb33495023a7966030faab5a69a3067eb (diff) | |
From didier gautheron: remove redundant or use faster col_xxx functions
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster.
- same for replace col_append_fstr and col_append_str
- remove col_clear() when it's redundant:
+ before a col_set/col_add if the dissector can't throw an exception.
- replace col_append() after a col_clear() with faster col_add... or col_set
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344
svn path=/trunk/; revision=52948
Diffstat (limited to 'epan/dissectors/packet-ieee80211.c')
| -rw-r--r-- | epan/dissectors/packet-ieee80211.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/dissectors/packet-ieee80211.c b/epan/dissectors/packet-ieee80211.c index af7d9bd895..a4de6d4c4e 100644 --- a/epan/dissectors/packet-ieee80211.c +++ b/epan/dissectors/packet-ieee80211.c @@ -5727,7 +5727,7 @@ static void dissect_hs20_anqp(proto_tree *tree, tvbuff_t *tvb, packet_info *pinf val_to_str(subtype, hs20_anqp_subtype_vals, "Unknown (%u)")); } else if (idx == 1) { - col_append_fstr(pinfo->cinfo, COL_INFO, ", .."); + col_append_str(pinfo->cinfo, COL_INFO, ", .."); } proto_tree_add_item(tree, hf_hs20_anqp_subtype, tvb, offset, 1, ENC_LITTLE_ENDIAN); @@ -5787,7 +5787,7 @@ dissect_anqp_info(proto_tree *tree, tvbuff_t *tvb, packet_info *pinfo, int offse val_to_str_ext(id, &anqp_info_id_vals_ext, "Unknown (%u)")); } else if (idx == 1) { proto_item_append_text(tree, ", .."); - col_append_fstr(pinfo->cinfo, COL_INFO, ", .."); + col_append_str(pinfo->cinfo, COL_INFO, ", .."); } } tree = proto_item_add_subtree(item, ett_gas_anqp); |