diff options
| author | Michael Mann <mmann78@netscape.net> | 2016-12-16 20:06:11 -0500 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-12-31 07:31:42 +0000 |
| commit | f4b0abc7296bbb431e64e31f85b24c29196c2ae4 (patch) | |
| tree | 68394f5fdfa1987900f0b079d0ecfd34003e8a5a /epan/dissectors/packet-hyperscsi.c | |
| parent | 13964595ad09e5d1115f6c5cb604cded27f9f55d (diff) | |
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-hyperscsi.c')
| -rw-r--r-- | epan/dissectors/packet-hyperscsi.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/epan/dissectors/packet-hyperscsi.c b/epan/dissectors/packet-hyperscsi.c index 80c1e0ea36..9571e11d18 100644 --- a/epan/dissectors/packet-hyperscsi.c +++ b/epan/dissectors/packet-hyperscsi.c @@ -41,6 +41,8 @@ static gint ett_hyperscsi = -1; static gint ett_hs_hdr = -1; static gint ett_hs_pdu = -1; +static dissector_handle_t hs_handle; + static const true_false_string tfs_lastfrag = { "Last Fragment", "Not Last Fragment" @@ -186,7 +188,7 @@ proto_register_hyperscsi(void) proto_register_field_array(proto_hyperscsi, hf, array_length(hf)); proto_register_subtree_array(ett, array_length(ett)); - register_dissector("hyperscsi", dissect_hyperscsi, proto_hyperscsi); + hs_handle = register_dissector("hyperscsi", dissect_hyperscsi, proto_hyperscsi); } /* XXX <epan/etypes.h> */ @@ -195,9 +197,6 @@ proto_register_hyperscsi(void) void proto_reg_handoff_hyperscsi(void) { - dissector_handle_t hs_handle; - - hs_handle = find_dissector("hyperscsi"); dissector_add_uint("ethertype", ETHERTYPE_HYPERSCSI, hs_handle); } |