diff options
| author | Michael Mann <mmann78@netscape.net> | 2013-09-15 01:48:30 +0000 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2013-09-15 01:48:30 +0000 |
| commit | b38ee917b1953104c615056481d6df008ae94b53 (patch) | |
| tree | 55024f9c53f083dc056540b6d887fc4550064008 /epan/dissectors/packet-hsr.c | |
| parent | a17cf67635c6e190c174bc131707804edca5c8f4 (diff) | |
Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly.
The script didn't catch as many as I would have liked, but it's a start.
The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum.
svn path=/trunk/; revision=52045
Diffstat (limited to 'epan/dissectors/packet-hsr.c')
| -rw-r--r-- | epan/dissectors/packet-hsr.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/epan/dissectors/packet-hsr.c b/epan/dissectors/packet-hsr.c index f312cb0f22..9d5c80e8c5 100644 --- a/epan/dissectors/packet-hsr.c +++ b/epan/dissectors/packet-hsr.c @@ -104,13 +104,13 @@ dissect_hsr_frame(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) lsdu_size = tvb_get_ntohs(tvb, HSR_PATH_OFFSET) & 0x0fff; lsdu_size_correct = tvb_reported_length_remaining(tvb, 0); if (lsdu_size == lsdu_size_correct) { - proto_tree_add_uint_format(hsr_tree, hf_hsr_lsdu_size, + proto_tree_add_uint_format_value(hsr_tree, hf_hsr_lsdu_size, tvb, HSR_PATH_OFFSET, HSR_LSDU_PATH_LENGTH, lsdu_size, - "LSDU size: %d [correct]", lsdu_size); + "%d [correct]", lsdu_size); } else { - proto_tree_add_uint_format(hsr_tree, hf_hsr_lsdu_size, + proto_tree_add_uint_format_value(hsr_tree, hf_hsr_lsdu_size, tvb, HSR_PATH_OFFSET, HSR_LSDU_PATH_LENGTH, lsdu_size, - "LSDU size: %d [WRONG, should be %d]", lsdu_size, lsdu_size_correct); + "%d [WRONG, should be %d]", lsdu_size, lsdu_size_correct); } proto_tree_add_item(hsr_tree, hf_hsr_sequence_nr, |