diff options
| author | Michael Mann <mmann78@netscape.net> | 2016-12-16 20:06:11 -0500 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-12-31 07:31:42 +0000 |
| commit | f4b0abc7296bbb431e64e31f85b24c29196c2ae4 (patch) | |
| tree | 68394f5fdfa1987900f0b079d0ecfd34003e8a5a /epan/dissectors/packet-gtp.c | |
| parent | 13964595ad09e5d1115f6c5cb604cded27f9f55d (diff) | |
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-gtp.c')
| -rw-r--r-- | epan/dissectors/packet-gtp.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/epan/dissectors/packet-gtp.c b/epan/dissectors/packet-gtp.c index 5c72f6d114..01d7d435c7 100644 --- a/epan/dissectors/packet-gtp.c +++ b/epan/dissectors/packet-gtp.c @@ -77,6 +77,7 @@ void proto_reg_handoff_gtp(void); static dissector_table_t ppp_subdissector_table; static dissector_table_t gtp_priv_ext_dissector_table; static dissector_table_t gtp_cdr_fmt_dissector_table; +static dissector_handle_t gtp_handle, gtp_prime_handle; #define GTPv0_PORT 3386 #define GTPv1C_PORT 2123 /* 3G Control PDU */ @@ -10134,8 +10135,8 @@ proto_register_gtp(void) prefs_register_bool_preference(gtp_module, "dissect_gtp_over_tcp", "Dissect GTP over TCP", "Dissect GTP over TCP", &g_gtp_over_tcp); prefs_register_bool_preference(gtp_module, "track_gtp_session", "Track GTP session", "Track GTP session", &g_gtp_session); - register_dissector("gtp", dissect_gtp, proto_gtp); - register_dissector("gtpprime", dissect_gtpprime, proto_gtpprime); + gtp_handle = register_dissector("gtp", dissect_gtp, proto_gtp); + gtp_prime_handle = register_dissector("gtpprime", dissect_gtpprime, proto_gtpprime); gtp_priv_ext_dissector_table = register_dissector_table("gtp.priv_ext", "GTP PRIVATE EXT", proto_gtp, FT_UINT16, BASE_DEC); gtp_cdr_fmt_dissector_table = register_dissector_table("gtp.cdr_fmt", "GTP DATA RECORD TYPE", proto_gtp, FT_UINT16, BASE_DEC); @@ -10162,15 +10163,12 @@ void proto_reg_handoff_gtp(void) { static gboolean Initialized = FALSE; - static dissector_handle_t gtp_handle, gtp_prime_handle; static gboolean gtp_over_tcp; static guint gtpv0_port; static guint gtpv1c_port; static guint gtpv1u_port; if (!Initialized) { - gtp_handle = find_dissector("gtp"); - gtp_prime_handle = find_dissector("gtpprime"); ppp_subdissector_table = find_dissector_table("ppp.protocol"); radius_register_avp_dissector(VENDOR_THE3GPP, 5, dissect_radius_qos_umts); |