diff options
author | Guy Harris <guy@alum.mit.edu> | 2005-06-26 19:56:52 +0000 |
---|---|---|
committer | Guy Harris <guy@alum.mit.edu> | 2005-06-26 19:56:52 +0000 |
commit | ab797734ddebd50f40deae437f27392ca4651c92 (patch) | |
tree | 82a95df0652f9df59634fd7a7f8dd36026fa4ea7 /epan/dissectors/packet-gsm_sms.c | |
parent | 2b07720c2fde93c0ee91e88969e76493ee7f86de (diff) |
Get rid of the private "my_match_strval()" routine in many dissectors;
add a "match_strval_idx()" routine that does the same thing, and have
"match_strval()" call it.
Make those routines, and "val_to_str()", return a "const" pointer.
Update dissectors as necessary to squelch compiler warnings produced by
that.
Use "val_to_str()" rather than using "match_strval()" and then, if the
result is null, substituting a specific string. Clean up some other
"match_strval()"/"val_to_str()" usages.
Add a null pointer check in the NDPS dissector's "attribute_value()"
routine, as it's not clear that "global_attribute_name" won't be null at
that point.
Make some global variables in the AFS4INT dissector local.
Make some routines not used outside the module they're in static.
Make some tables "static const".
Clean up white space.
Fix Gerald's address in some files.
svn path=/trunk/; revision=14786
Diffstat (limited to 'epan/dissectors/packet-gsm_sms.c')
-rw-r--r-- | epan/dissectors/packet-gsm_sms.c | 23 |
1 files changed, 2 insertions, 21 deletions
diff --git a/epan/dissectors/packet-gsm_sms.c b/epan/dissectors/packet-gsm_sms.c index e1c0b23f48..4c4712927f 100644 --- a/epan/dissectors/packet-gsm_sms.c +++ b/epan/dissectors/packet-gsm_sms.c @@ -140,25 +140,6 @@ static gint ett_udh_ieis[NUM_UDH_IEIS]; /* FUNCTIONS */ -gchar * -my_match_strval(guint32 val, const value_string *vs, gint *idx) -{ - gint i = 0; - - while (vs[i].strptr) { - if (vs[i].value == val) - { - *idx = i; - return(vs[i].strptr); - } - - i++; - } - - *idx = -1; - return(NULL); -} - /* 9.2.3.1 */ #define DIS_FIELD_MTI(m_tree, m_bitmask, m_offset) \ { \ @@ -2523,7 +2504,7 @@ dissect_gsm_sms(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) guint8 msg_type; guint8 oct; gint idx; - gchar *str = NULL; + const gchar *str = NULL; gint ett_msg_idx; @@ -2564,7 +2545,7 @@ dissect_gsm_sms(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) msg_type |= ((pinfo->p2p_dir == P2P_DIR_RECV) ? 0x04 : 0x00); } - str = my_match_strval(msg_type, msg_type_strings, &idx); + str = match_strval_idx(msg_type, msg_type_strings, &idx); /* * create the GSM_SMS protocol tree |