diff options
| author | Martin Mathieson <martin.mathieson@keysight.com> | 2020-04-04 22:16:40 +0100 |
|---|---|---|
| committer | Martin Mathieson <martin.r.mathieson@googlemail.com> | 2020-04-05 17:40:21 +0000 |
| commit | ec781e9749c1329efb6a288668a1809b9d418ec0 (patch) | |
| tree | 2f63a2fcfa17e5cdf956ba2770679f10c05ab910 /epan/dissectors/packet-gsm_map.c | |
| parent | 361f82fe5a0f511f3bfab0185b102767f106eb65 (diff) | |
proto: Add a debug check to sanity-check range_string
Check is enabled by #ifdef ENABLE_CHECK_FILTER
Remaining issues found by this check are fixed here,
along with a documentation note that the entries
are checked in order and the first match is used.
The only issue not yet fixed is in packet-isup.c,
where the spec was not available to me.
Change-Id: Ife747cda9b91a265bc2b81ce0a53f55f3389919e
Reviewed-on: https://code.wireshark.org/review/36708
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Diffstat (limited to 'epan/dissectors/packet-gsm_map.c')
| -rw-r--r-- | epan/dissectors/packet-gsm_map.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/epan/dissectors/packet-gsm_map.c b/epan/dissectors/packet-gsm_map.c index a0aa235786..0b68191577 100644 --- a/epan/dissectors/packet-gsm_map.c +++ b/epan/dissectors/packet-gsm_map.c @@ -2963,7 +2963,6 @@ static const range_string gsm_map_na_vals[] = { { 3, 3, "national (significant) number (national use)" }, { 4, 4, "international number" }, { 5, 0x6f, "spare" }, - { 0x70, 0x7e, "spare" }, { 0x70, 0x7e, "reserved for national use" }, { 0x7f, 0x7f, "spare" }, { 0, 0, NULL } @@ -22054,7 +22053,7 @@ dissect_NokiaMAP_Extensions_AllowedServiceData(gboolean implicit_tag _U_, tvbuff /*--- End of included file: packet-gsm_map-fn.c ---*/ -#line 1102 "./asn1/gsm_map/packet-gsm_map-template.c" +#line 1101 "./asn1/gsm_map/packet-gsm_map-template.c" /* Specific translation for MAP V3 */ const value_string gsm_map_V1V2_opr_code_strings[] = { @@ -22277,7 +22276,7 @@ const value_string gsm_map_opr_code_strings[] = { /* Unknown or empty loop list OPERATION */ /*--- End of included file: packet-gsm_map-table.c ---*/ -#line 1113 "./asn1/gsm_map/packet-gsm_map-template.c" +#line 1112 "./asn1/gsm_map/packet-gsm_map-template.c" { 0, NULL } }; @@ -22495,7 +22494,7 @@ static const value_string gsm_map_err_code_string_vals[] = { /* Unknown or empty loop list OPERATION */ /*--- End of included file: packet-gsm_map-table.c ---*/ -#line 1119 "./asn1/gsm_map/packet-gsm_map-template.c" +#line 1118 "./asn1/gsm_map/packet-gsm_map-template.c" { 0, NULL } }; #endif @@ -32116,7 +32115,7 @@ void proto_register_gsm_map(void) { NULL, HFILL }}, /*--- End of included file: packet-gsm_map-hfarr.c ---*/ -#line 3410 "./asn1/gsm_map/packet-gsm_map-template.c" +#line 3409 "./asn1/gsm_map/packet-gsm_map-template.c" }; /* List of subtrees */ @@ -32871,7 +32870,7 @@ void proto_register_gsm_map(void) { &ett_NokiaMAP_Extensions_AllowedServiceData, /*--- End of included file: packet-gsm_map-ettarr.c ---*/ -#line 3449 "./asn1/gsm_map/packet-gsm_map-template.c" +#line 3448 "./asn1/gsm_map/packet-gsm_map-template.c" }; static ei_register_info ei[] = { @@ -33015,7 +33014,7 @@ void proto_register_gsm_map(void) { /*--- End of included file: packet-gsm_map-dis-tab.c ---*/ -#line 3509 "./asn1/gsm_map/packet-gsm_map-template.c" +#line 3508 "./asn1/gsm_map/packet-gsm_map-template.c" oid_add_from_string("ericsson-gsm-Map-Ext","1.2.826.0.1249.58.1.0" ); oid_add_from_string("accessTypeNotAllowed-id","1.3.12.2.1107.3.66.1.2"); /*oid_add_from_string("map-ac networkLocUp(1) version3(3)","0.4.0.0.1.0.1.3" ); |