diff options
| author | Vadim Yanitskiy <axilirator@gmail.com> | 2018-06-16 16:11:25 +0700 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2018-06-16 11:07:10 +0000 |
| commit | 580b2e13f104a4890451664f9018ca60902300fb (patch) | |
| tree | 1710dcb14bfe487f993e42f6cdd1dbdaffd1bf9c /epan/dissectors/packet-gsm_gsup.c | |
| parent | 1a8ed6fa2807893c15c9220453bf1e59f47f4982 (diff) | |
GSUP: fix incorrect message types
In the reference libosmocore's implementation we have:
OSMO_GSUP_MSGT_PURGE_MS_REQUEST = 0b00001100, // 0x0c
OSMO_GSUP_MSGT_PURGE_MS_ERROR = 0b00001101, // 0x0d
OSMO_GSUP_MSGT_PURGE_MS_RESULT = 0b00001110, // 0x0e
while here we had:
OSMO_GSUP_MSGT_PURGE_MS_REQUEST = 0x0c,
OSMO_GSUP_MSGT_PURGE_MS_ERROR = 0x0e, // != 0x0d
OSMO_GSUP_MSGT_PURGE_MS_RESULT = 0x0f, // != 0x0e
Same problem with the 'OSMO_GSUP_MSGT_LOCATION_CANCEL_RESULT'.
Change-Id: Ie49fd2fca8298d97c21e03649935704309015324
Reviewed-on: https://code.wireshark.org/review/28297
Reviewed-by: Harald Welte <laforge@gnumonks.org>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-gsm_gsup.c')
| -rw-r--r-- | epan/dissectors/packet-gsm_gsup.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/epan/dissectors/packet-gsm_gsup.c b/epan/dissectors/packet-gsm_gsup.c index e67e412a43..0072c8dd03 100644 --- a/epan/dissectors/packet-gsm_gsup.c +++ b/epan/dissectors/packet-gsm_gsup.c @@ -97,8 +97,8 @@ enum osmo_gsup_message_type { OSMO_GSUP_MSGT_AUTH_FAIL_REPORT = 0x0b, OSMO_GSUP_MSGT_PURGE_MS_REQUEST = 0x0c, - OSMO_GSUP_MSGT_PURGE_MS_ERROR = 0x0e, - OSMO_GSUP_MSGT_PURGE_MS_RESULT = 0x0f, + OSMO_GSUP_MSGT_PURGE_MS_ERROR = 0x0d, + OSMO_GSUP_MSGT_PURGE_MS_RESULT = 0x0e, OSMO_GSUP_MSGT_INSERT_DATA_REQUEST = 0x10, OSMO_GSUP_MSGT_INSERT_DATA_ERROR = 0x11, @@ -110,7 +110,7 @@ enum osmo_gsup_message_type { OSMO_GSUP_MSGT_LOCATION_CANCEL_REQUEST = 0x1c, OSMO_GSUP_MSGT_LOCATION_CANCEL_ERROR = 0x1d, - OSMO_GSUP_MSGT_LOCATION_CANCEL_RESULT = 0x1f, + OSMO_GSUP_MSGT_LOCATION_CANCEL_RESULT = 0x1e, }; #define OSMO_GSUP_IS_MSGT_REQUEST(msgt) (((msgt) & 0b00000011) == 0b00) |