diff options
| author | Harald Welte <laforge@gnumonks.org> | 2018-08-07 16:47:00 +0200 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2018-08-09 07:01:23 +0000 |
| commit | b2d7da58a4faf6d2eaa1c2617989269f3f1e98b7 (patch) | |
| tree | 40cef1ead71fb2ff27e79385192c54deac32f6fd /epan/dissectors/packet-gsm_gsup.c | |
| parent | 297a6fe2f70d5356b88539f093aea32c06d20643 (diff) | |
gsup: Don't print IEI + Length twice for unknown IEs
The handling for unknown IEs was flawed in that it printed
the IEI and the IE Length lines twice: Once the general code before
the switch statement, and then a second time inside the default
case handling.
Change-Id: Ic845bfb79e9ff881b39f709e3bff407e352c49fd
Reviewed-on: https://code.wireshark.org/review/29005
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-gsm_gsup.c')
| -rw-r--r-- | epan/dissectors/packet-gsm_gsup.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/epan/dissectors/packet-gsm_gsup.c b/epan/dissectors/packet-gsm_gsup.c index 6f5e0624f7..78c849712c 100644 --- a/epan/dissectors/packet-gsm_gsup.c +++ b/epan/dissectors/packet-gsm_gsup.c @@ -403,9 +403,7 @@ dissect_gsup_tlvs(tvbuff_t *tvb, int base_offs, int length, packet_info *pinfo, case OSMO_GSUP_PDP_TYPE_IE: case OSMO_GSUP_PDP_QOS_IE: default: - /* Unknown/unsupported IE: Print IEI, Length and Payload */ - proto_tree_add_item(att_tree, hf_gsup_iei, tvb, offset-2, 1, ENC_BIG_ENDIAN); - proto_tree_add_uint(att_tree, hf_gsup_ie_len, tvb, offset-1, 1, len); + /* Unknown/unsupported IE: Print raw payload in addition to IEI + Length printed above */ proto_tree_add_item(att_tree, hf_gsup_ie_payload, tvb, offset, len, ENC_NA); break; } |