aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gsm_a_common.h
diff options
context:
space:
mode:
authorVadim Yanitskiy <vyanitskiy@sysmocom.de>2020-06-29 11:26:43 +0700
committerAnders Broman <a.broman58@gmail.com>2020-07-02 06:18:27 +0000
commit39b4d2eb3e9911937b9119f80dd0b6c59b809ebc (patch)
tree860fbb379e0e5c186d622e4698b33088cf627cf1 /epan/dissectors/packet-gsm_a_common.h
parent408bc4cb1dbfccf5638fbefb6cfb8084d9d4794b (diff)
A-bis/RSL: fix dissection of Mobile Allocation in CHANnel ACTIVation
According to 3GPP TS 48.058 (version 15.0.0), section 9.3.5, 3GPP TS 44.018 "Mobile Allocation" IE shall for compatibility reasons be included but empty, i.e. the length shall be zero. It does not mean that the Mobile Allocation IE should not be decoded by Wireshark though. Some BSC implementations may still be sending it with length greather than 0. Let's expose de_rr_mob_all() and use it in dissect_rsl_ie_ch_id(). If the length is greather than 0, raise a protocol warning. Change-Id: Idd0f2b3cd1e684f2c812b566fde71a1cc727c2c4 Signed-off-by: Vadim Yanitskiy <vyanitskiy@sysmocom.de> Reviewed-on: https://code.wireshark.org/review/37575 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-gsm_a_common.h')
-rw-r--r--epan/dissectors/packet-gsm_a_common.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/epan/dissectors/packet-gsm_a_common.h b/epan/dissectors/packet-gsm_a_common.h
index 33eb75aa5d..5f9f48bfe9 100644
--- a/epan/dissectors/packet-gsm_a_common.h
+++ b/epan/dissectors/packet-gsm_a_common.h
@@ -774,6 +774,7 @@ guint16 de_rr_cip_mode_set(tvbuff_t *tvb, proto_tree *tree, packet_info *pinfo,
WS_DLL_PUBLIC
guint16 de_rr_cm_enq_mask(tvbuff_t *tvb, proto_tree *tree, packet_info *pinfo, guint32 offset, guint len, gchar *add_string, int string_len);
guint16 de_rr_meas_res(tvbuff_t *tvb, proto_tree *tree, packet_info *pinfo, guint32 offset, guint len, gchar *add_string, int string_len);
+guint16 de_rr_mob_all(tvbuff_t *tvb, proto_tree *tree, packet_info *pinfo, guint32 offset, guint len, gchar *add_string, int string_len);
WS_DLL_PUBLIC
guint16 de_rr_multirate_conf(tvbuff_t *tvb, proto_tree *tree, packet_info *pinfo, guint32 offset, guint len, gchar *add_string, int string_len);
WS_DLL_PUBLIC