diff options
author | Bill Meier <wmeier@newsguy.com> | 2013-10-29 14:09:20 +0000 |
---|---|---|
committer | Bill Meier <wmeier@newsguy.com> | 2013-10-29 14:09:20 +0000 |
commit | 0ad98563a24b8685545825aac889ef43bfc58809 (patch) | |
tree | d44e5d34582bc2a05ba6be6bd8d818e9a813147f /epan/dissectors/packet-gopher.c | |
parent | 86c145ecb33495023a7966030faab5a69a3067eb (diff) |
From didier gautheron: remove redundant or use faster col_xxx functions
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster.
- same for replace col_append_fstr and col_append_str
- remove col_clear() when it's redundant:
+ before a col_set/col_add if the dissector can't throw an exception.
- replace col_append() after a col_clear() with faster col_add... or col_set
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344
svn path=/trunk/; revision=52948
Diffstat (limited to 'epan/dissectors/packet-gopher.c')
-rw-r--r-- | epan/dissectors/packet-gopher.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/dissectors/packet-gopher.c b/epan/dissectors/packet-gopher.c index 3b99e12df3..d40acd0eab 100644 --- a/epan/dissectors/packet-gopher.c +++ b/epan/dissectors/packet-gopher.c @@ -169,7 +169,7 @@ dissect_gopher(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data _ while (find_dir_tokens(tvb, offset + 1, &sel_start, &host_start, &port_start, &line_len, &next_offset)) { if (!is_dir) { /* First time */ proto_item_append_text(ti, "[Directory list]"); - col_append_fstr(pinfo->cinfo, COL_INFO, ": [Directory list]"); + col_append_str(pinfo->cinfo, COL_INFO, ": [Directory list]"); } name = tvb_get_string(wmem_packet_scope(), tvb, offset + 1, sel_start - offset - 2); |