aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-giop.c
diff options
context:
space:
mode:
authoretxrab <etxrab@f5534014-38df-0310-8fa8-9805f1628bb7>2008-09-11 19:33:07 +0000
committeretxrab <etxrab@f5534014-38df-0310-8fa8-9805f1628bb7>2008-09-11 19:33:07 +0000
commitb66ac54e751cbba258601ebe2704fa3fcdd6892a (patch)
treeb8c17192d477eaaabe5eff0906df481b761fa059 /epan/dissectors/packet-giop.c
parent007813964c4564970fad1fecf00a01d68505e671 (diff)
"Response flags" in GIOP Request is misinterpreted
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2800 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26177 f5534014-38df-0310-8fa8-9805f1628bb7
Diffstat (limited to 'epan/dissectors/packet-giop.c')
-rw-r--r--epan/dissectors/packet-giop.c14
1 files changed, 12 insertions, 2 deletions
diff --git a/epan/dissectors/packet-giop.c b/epan/dissectors/packet-giop.c
index 551d8e9379..8b95fb5ae6 100644
--- a/epan/dissectors/packet-giop.c
+++ b/epan/dissectors/packet-giop.c
@@ -471,7 +471,7 @@ static const value_string giop_endianess_vals[] = {
{ 0x1, "Little Endian" },
{ 0, NULL}
};
-
+/*
static const value_string sync_scope[] = {
{ 0x0, "SYNC_NONE" },
{ 0x1, "SYNC_WITH_TRANSPORT"},
@@ -479,6 +479,16 @@ static const value_string sync_scope[] = {
{ 0x3, "SYNC_WITH_TARGET"},
{ 0, NULL}
};
+Bug fix:
+https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2800
+http://ethereal.netmirror.org/lists/ethereal-users/200303/msg00135.html
+*/
+static const value_string response_flags_vals[] = {
+ { 0x0, "SyncScope NONE or WITH_TRANSPORT" },
+ { 0x1, "SyncScope WITH_SERVER"},
+ { 0x3, "SyncScope WITH_TARGET"},
+ { 0, NULL}
+};
/* Profile ID's */
@@ -3519,7 +3529,7 @@ dissect_giop_request_1_2 (tvbuff_t * tvb, packet_info * pinfo,
{
proto_tree_add_text (request_tree, tvb, offset-1, 1,
"Response flags: %s (%u)",
- val_to_str(response_flags, sync_scope, "(0x%x)"),
+ val_to_str(response_flags, response_flags_vals, "(0x%x)"),
response_flags);
}