diff options
| author | Guy Harris <guy@alum.mit.edu> | 2015-07-18 23:23:32 -0700 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2015-07-19 06:24:18 +0000 |
| commit | 7e817aeb3a3cee7c3eb3e7685ab0ccf98a00411b (patch) | |
| tree | f78ac4b87035ce2db1c46386be5955e26412bf75 /epan/dissectors/packet-fmp_notify.c | |
| parent | 75d4fa299da240d5598b963602fa3b0c1d133dcb (diff) | |
Require dissectors for all ONC RPC calls and replies.
Either there's a known body for the call or reply, in which case we
already have a dissector for it, or the body is empty, in which case we
now have dissect_rpc_void() to dissect it, or the body is unknown or
nobody's bothered writing it, in which case we use dissect_rpc_unknown()
for now.
This means that an attempt to look up the dissector for a known
procedure will always succeed, so we can label it with the name rather
than with "proc-N".
It also means that we distinguish between "it's void" and "it's
unknown", so that unknown values will get flagged as such.
Change-Id: I748580c1dca61d1f0972396db1a3b0885fc0a541
Reviewed-on: https://code.wireshark.org/review/9699
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'epan/dissectors/packet-fmp_notify.c')
| -rw-r--r-- | epan/dissectors/packet-fmp_notify.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/epan/dissectors/packet-fmp_notify.c b/epan/dissectors/packet-fmp_notify.c index a1183a9ac2..6fa4f78db6 100644 --- a/epan/dissectors/packet-fmp_notify.c +++ b/epan/dissectors/packet-fmp_notify.c @@ -365,9 +365,11 @@ dissect_FMP_NOTIFY_revokeHandleList_reply(tvbuff_t *tvb, /* * proc number, "proc name", dissect_request, dissect_reply - * NULL as function pointer means: type of arguments is "void". */ static const vsff fmp_notify2_proc[] = { + { 0, "NULL", + dissect_rpc_void, + dissect_rpc_void, }, { FMP_NOTIFY_DownGrade, "DownGrade", dissect_FMP_NOTIFY_DownGrade_request, @@ -401,6 +403,7 @@ static const vsff fmp_notify2_proc[] = { }; static const value_string fmp_notify_proc_vals[] = { + { 0, "NULL" }, { 1, "DownGrade" }, { 2, "RevokeList" }, { 3, "RevokeAll" }, @@ -408,7 +411,6 @@ static const value_string fmp_notify_proc_vals[] = { { 5, "RequestDone" }, { 6, "VolFreeze" }, { 7, "RevokeHandleList" }, - { 0, "NULL" }, { 0,NULL} }; |