diff options
| author | Bill Meier <wmeier@newsguy.com> | 2014-03-03 13:27:24 -0500 |
|---|---|---|
| committer | Bill Meier <wmeier@newsguy.com> | 2014-03-03 18:36:29 +0000 |
| commit | 1795b4021c43c3a8bfc90a4303fb9ce17f5f26bd (patch) | |
| tree | 8fd8a76d94157b3f8f35ce6090f4c64818a5b14e /epan/dissectors/packet-fcp.c | |
| parent | 1f2f2ba5fa54586cfaa858004bfe021394be9c19 (diff) | |
Move value_string defs from .h file; create/use extended value_string; Other minor changes.
- Multiple value string arrays were defined in packet-fcels.h (which was included
in two differnt .c files). Only one of the arrays was actually used in two
different .c files. All the value_string arrays (and most of the #defines)
moved to packet-fcels.c.
- Other:
Use -1 instead of tvb_length() for the length param of several proto_tree_add...() calls.
Add editor modelines.
Change-Id: Idc642caf1c8d62b658147a234d5560b8f2fd0630
Reviewed-on: https://code.wireshark.org/review/479
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
Diffstat (limited to 'epan/dissectors/packet-fcp.c')
| -rw-r--r-- | epan/dissectors/packet-fcp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/dissectors/packet-fcp.c b/epan/dissectors/packet-fcp.c index 7942819ad4..82ce463372 100644 --- a/epan/dissectors/packet-fcp.c +++ b/epan/dissectors/packet-fcp.c @@ -701,9 +701,9 @@ dissect_fcp_els(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, fc_hdr *fch guint8 op; op = tvb_get_guint8(tvb, 0); - col_add_str(pinfo->cinfo, COL_INFO, val_to_str(op, fc_els_proto_val, "0x%x")); + col_add_str(pinfo->cinfo, COL_INFO, val_to_str_ext(op, &fc_els_proto_val_ext, "0x%x")); proto_tree_add_text(tree, tvb, 0, 1, "Opcode: %s", - val_to_str(op, fc_els_proto_val, + val_to_str_ext(op, &fc_els_proto_val_ext, "ELS 0x%02x")); switch (op) { /* XXX should switch based on conv for LS_ACC */ |