diff options
| author | Michael Mann <mmann78@netscape.net> | 2013-09-15 01:48:30 +0000 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2013-09-15 01:48:30 +0000 |
| commit | b38ee917b1953104c615056481d6df008ae94b53 (patch) | |
| tree | 55024f9c53f083dc056540b6d887fc4550064008 /epan/dissectors/packet-fcoe.c | |
| parent | a17cf67635c6e190c174bc131707804edca5c8f4 (diff) | |
Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly.
The script didn't catch as many as I would have liked, but it's a start.
The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum.
svn path=/trunk/; revision=52045
Diffstat (limited to 'epan/dissectors/packet-fcoe.c')
| -rw-r--r-- | epan/dissectors/packet-fcoe.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/epan/dissectors/packet-fcoe.c b/epan/dissectors/packet-fcoe.c index d963a25613..375460d99b 100644 --- a/epan/dissectors/packet-fcoe.c +++ b/epan/dissectors/packet-fcoe.c @@ -214,14 +214,13 @@ dissect_fcoe(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) */ if (crc_exists) { if (crc == crc_computed) { - item = proto_tree_add_uint_format(fcoe_tree, hf_fcoe_crc, tvb, + item = proto_tree_add_uint_format_value(fcoe_tree, hf_fcoe_crc, tvb, crc_offset, 4, crc, - "CRC: %8.8x [valid]", crc); + "%8.8x [valid]", crc); } else { - item = proto_tree_add_uint_format(fcoe_tree, hf_fcoe_crc, tvb, + item = proto_tree_add_uint_format_value(fcoe_tree, hf_fcoe_crc, tvb, crc_offset, 4, crc, - "CRC: %8.8x " - "[error: should be %8.8x]", + "%8.8x [error: should be %8.8x]", crc, crc_computed); expert_add_info_format(pinfo, item, &ei_fcoe_crc, "Bad FC CRC %8.8x %8.x", |